Open-source eCommerce platform for C# and ASP.NET Core 10 with MongoDB. Build multi-store shops and multi-vendor marketplaces with B2B/B2C, REST API, plugins, Vue 3 and Docker.
C# aspnet-corecsharpdockerdotnetecommerceecommerce-platformmongodbmulti-storemulti-vendornosqlonline-shopshoppingcart
Add regex match timeout to ApiQueryOptions (#816)
Copilot8d0872f2719e
diff --git a/src/Modules/Grand.Module.Api/Queries/ApiQueryOptions.cs b/src/Modules/Grand.Module.Api/Queries/ApiQueryOptions.csindex c06dcdc76..5c85abae0 100644--- a/src/Modules/Grand.Module.Api/Queries/ApiQueryOptions.cs+++ b/src/Modules/Grand.Module.Api/Queries/ApiQueryOptions.cs@@ -43,13 +43,19 @@ public static class ApiQueryOptions"and", "or", "not", "true", "false", "null", "iif"};- private static readonly Regex Identifier = new(@"[A-Za-z_][A-Za-z0-9_]*", RegexOptions.Compiled);+ /// <summary>+ /// A bounded execution budget so a pathological input cannot make regex matching the slow part+ /// of the request; both patterns below are cheap on well-formed input, so this should never trip.+ /// </summary>+ private static readonly TimeSpan RegexTimeout = TimeSpan.FromMilliseconds(200);++ private static readonly Regex Identifier = new(@"[A-Za-z_][A-Za-z0-9_]*", RegexOptions.Compiled, RegexTimeout);/// <summary>/// String literals hold user text, not member names, so they are removed before the whitelist/// runs - otherwise a product named "Password" would fail its own search./// </summary>- private static readonly Regex StringLiteral = new(@"""(?:[^""\\]|\\.)*""|'(?:[^'\\]|\\.)*'", RegexOptions.Compiled);+ private static readonly Regex StringLiteral = new(@"""(?:[^""\\]|\\.)*""|'(?:[^'\\]|\\.)*'", RegexOptions.Compiled, RegexTimeout);/// <summary>/// Denies everything the parser can reach outside the model: no type resolution, no `it`/`root`