Skip to content

Open-source eCommerce platform for C# and ASP.NET Core 10 with MongoDB. Build multi-store shops and multi-vendor marketplaces with B2B/B2C, REST API, plugins, Vue 3 and Docker.

Task 12 fix round 1: correct stale doc comment, escalate review's orphaned-file findings into Task 13's plan

KrzysztofPajakb521a35f1f49
diff --git a/docs/superpowers/plans/2026-08-16-arch001-product-consolidation-phase1.md b/docs/superpowers/plans/2026-08-16-arch001-product-consolidation-phase1.md
index 4604e77e1..f507ce950 100644
--- a/docs/superpowers/plans/2026-08-16-arch001-product-consolidation-phase1.md
+++ b/docs/superpowers/plans/2026-08-16-arch001-product-consolidation-phase1.md
@@ -1429,9 +1429,19 @@ git commit -m "Delete Vendor's duplicate ProductViewModelService/interface, use
## Task 13: Consolidate characterization tests, delete superseded per-host duplicates
+**Status update (added after Task 11/12's reviews):** Admin's and Store's per-host
+`ProductControllerTests.cs` were already fully deleted during Task 11 (they no longer compiled against
+the new thin-subclass constructor) and replaced with routing/attribute-only coverage
+(`ProductControllerAttributesTests.cs` in each of `Grand.Web.Admin.Tests`/`Grand.Web.Store.Tests`, plus
+`Grand.Web.Store.Tests/Controllers/ProductControllerTests.cs` for the `EditWarningCheck` hook) — Steps
+1-2 below are already done for those two hosts; only Vendor's equivalent remains.
+
+**Additional files, added after Task 12's review (opus) found them:**
+- Delete: `src/Web/Grand.Web.Vendor/Models/Catalog/*.cs` (ProductModel.cs, ProductAttributeCombinationModel.cs, ProductAttributeConditionModel.cs, ProductSpecificationAttributeModel.cs, IProductValidVendor.cs, BulkEditListModel.cs, BulkEditProductModel.cs, CopyProductModel.cs, ProductAttributeModel.cs, ProductListModel.cs, ProductReviewModel.cs) — orphaned since Task 12 repointed `_ViewImports.cshtml` to AdminShared's models; confirmed nothing in `src/Web` still binds them except the files below.
+- Delete: `src/Web/Grand.Web.Vendor/Mapper/ProductProfile.cs`, `src/Web/Grand.Web.Vendor/Extensions/ProductsMappingExtensions.cs` — also orphaned; the latter defines `ToModel`/`ToEntity` extension methods returning the dead Vendor models, which would silently shadow if anything ever called them again, so delete rather than leave as inert.
+- Modify: `src/Tests/Grand.Mapping.Tests/Vendor/VendorMappingTests.cs` — also binds `Grand.Web.Vendor.Models.Catalog`; will fail to compile once the above are deleted. Trim/delete its Product-related cases the same way as the controller test files, or delete the file outright if nothing else in it survives.
+
**Files:**
-- Modify/trim: `src/Tests/Grand.Web.Admin.Tests/Controllers/ProductControllerTests.cs`
-- Modify/trim: `src/Tests/Grand.Web.Store.Tests/Controllers/ProductControllerTests.cs`
- Modify/trim: `src/Tests/Grand.Web.Vendor.Tests/Controllers/ProductControllerTests.cs`
- Delete: `src/Tests/Grand.Web.Vendor.Tests/Services/ProductViewModelServiceTests.cs` (superseded by `Grand.Web.Admin.Tests/Services/ProductViewModelServiceTests.cs`, which now covers all scope variants per Tasks 9-10)
diff --git a/src/Web/Grand.Web.Vendor/Controllers/ProductController.cs b/src/Web/Grand.Web.Vendor/Controllers/ProductController.cs
index 3ff638099..dc6ba4691 100644
--- a/src/Web/Grand.Web.Vendor/Controllers/ProductController.cs
+++ b/src/Web/Grand.Web.Vendor/Controllers/ProductController.cs
@@ -23,12 +23,10 @@ namespace Grand.Web.Vendor.Controllers;
// so each subclass restates its own host's attribute set explicitly. No EditWarningCheck override
// needed - Vendor's original had no equivalent branch.
//
-// NOT wired into DI yet: this file compiles fine (it references AdminShared's IProductViewModelService
-// directly), but Vendor's DI container still only registers its own old, duplicate
-// Grand.Web.Vendor.Interfaces.IProductViewModelService/ProductViewModelService - nothing registers
-// AdminShared's IProductViewModelService for Vendor yet, so this constructor cannot be resolved at
-// runtime until Task 12 deletes Vendor's duplicate and rewires DI to AdminShared's implementation (see
-// Task 11's plan Step 4). Left as an uncommitted working-tree change per plan Step 5 until Task 12.
+// DI wiring: resolves via AdminShared's own IStartupApplication (Priority 101), which registers
+// IProductViewModelService for any host referencing the AdminShared assembly - including Vendor.
+// Vendor's own duplicate registration was removed in Task 12, alongside the duplicate service/interface
+// it pointed at.
[AutoValidateAntiforgeryToken]
[Area(Constants.AreaVendor)]
[AuthorizeVendor]