Skip to content

Open-source eCommerce platform for C# and ASP.NET Core 10 with MongoDB. Build multi-store shops and multi-vendor marketplaces with B2B/B2C, REST API, plugins, Vue 3 and Docker.

feat(arch001): add order item actions region (Save/Delete/Cancel/ResetDownload/ActivateDownload)

KrzysztofPajakd95c19412f82
diff --git a/src/Tests/Grand.Web.Admin.Tests/Controllers/BaseOrderManagementControllerTests.cs b/src/Tests/Grand.Web.Admin.Tests/Controllers/BaseOrderManagementControllerTests.cs
index 5278e0e5f..74cdf8e55 100644
--- a/src/Tests/Grand.Web.Admin.Tests/Controllers/BaseOrderManagementControllerTests.cs
+++ b/src/Tests/Grand.Web.Admin.Tests/Controllers/BaseOrderManagementControllerTests.cs
@@ -164,4 +164,43 @@ public class BaseOrderManagementControllerTests
Assert.AreEqual(99.0, order.OrderTotal);
_orderServiceMock.Verify(s => s.InsertOrderNote(It.Is<OrderNote>(n => n.Note == "Order totals have been edited")), Times.Once);
}
+
+ [TestMethod]
+ public async Task SaveOrderItem_ScopeDenies_RedirectsToList_NoCommandSent()
+ {
+ var order = new Order { Id = "o1" };
+ _orderServiceMock.Setup(s => s.GetOrderById("o1")).ReturnsAsync(order);
+ _scopeMock.Setup(s => s.HasAccess(order)).ReturnsAsync(false);
+
+ var result = await _controller.SaveOrderItem("o1", new OrderItemsModel(new List<OrderItemModel>(), "i1"));
+
+ Assert.AreEqual("List", (result as RedirectToActionResult)?.ActionName);
+ _mediatorMock.Verify(m => m.Send(It.IsAny<UpdateOrderItemCommand>(), default), Times.Never);
+ }
+
+ [TestMethod]
+ public async Task SaveOrderItem_OrderCancelled_ErrorsWithoutSendingCommand()
+ {
+ var order = new Order { Id = "o1", OrderStatusId = (int)OrderStatusSystem.Cancelled };
+ _orderServiceMock.Setup(s => s.GetOrderById("o1")).ReturnsAsync(order);
+ _scopeMock.Setup(s => s.HasAccess(order)).ReturnsAsync(true);
+
+ var result = await _controller.SaveOrderItem("o1", new OrderItemsModel(new List<OrderItemModel>(), "i1"));
+
+ Assert.AreEqual("Edit", (result as RedirectToActionResult)?.ActionName);
+ _mediatorMock.Verify(m => m.Send(It.IsAny<UpdateOrderItemCommand>(), default), Times.Never);
+ }
+
+ [TestMethod]
+ public async Task DeleteOrderItem_ScopeDenies_RedirectsToList_NoCommandSent()
+ {
+ var order = new Order { Id = "o1" };
+ _orderServiceMock.Setup(s => s.GetOrderById("o1")).ReturnsAsync(order);
+ _scopeMock.Setup(s => s.HasAccess(order)).ReturnsAsync(false);
+
+ var result = await _controller.DeleteOrderItem("o1", "i1");
+
+ Assert.AreEqual("List", (result as RedirectToActionResult)?.ActionName);
+ _mediatorMock.Verify(m => m.Send(It.IsAny<DeleteOrderItemCommand>(), default), Times.Never);
+ }
}
diff --git a/src/Web/Grand.Web.AdminShared/Controllers/BaseOrderManagementController.cs b/src/Web/Grand.Web.AdminShared/Controllers/BaseOrderManagementController.cs
index f9b4628d1..9c6d10aa9 100644
--- a/src/Web/Grand.Web.AdminShared/Controllers/BaseOrderManagementController.cs
+++ b/src/Web/Grand.Web.AdminShared/Controllers/BaseOrderManagementController.cs
@@ -202,4 +202,133 @@ public abstract class BaseOrderManagementController(
}
#endregion
+
+ #region Order items
+
+ [PermissionAuthorizeAction(PermissionActionName.Edit)]
+ [HttpPost]
+ public async Task<IActionResult> SaveOrderItem(string id, OrderItemsModel model)
+ {
+ var (order, denied) = await LoadAuthorizedOrder(id);
+ if (denied != null) return denied;
+
+ if (order.OrderStatusId == (int)OrderStatusSystem.Cancelled)
+ {
+ Error("You can't edit position when order is canceled");
+ return RedirectToAction("Edit", "Order", new { id });
+ }
+
+ var orderItem = order.OrderItems.FirstOrDefault(x => x.Id == model.OrderItemId)
+ ?? throw new ArgumentException("No order item found with the specified id");
+ var itemModel = model.Items.FirstOrDefault(x => x.Id == model.OrderItemId)
+ ?? throw new ArgumentException("No order item model found with the specified id");
+
+ if (itemModel.Quantity == 0 || (orderItem.OpenQty != orderItem.Quantity && orderItem.IsShipEnabled))
+ {
+ Error("You can't change quantity");
+ return RedirectToAction("Edit", "Order", new { id });
+ }
+
+ if (orderItem.Quantity == itemModel.Quantity && orderItem.UnitPriceExclTax == itemModel.UnitPriceExclTaxValue)
+ {
+ Error("Nothing has been changed");
+ return RedirectToAction("Edit", "Order", new { id });
+ }
+
+ orderItem.Quantity = itemModel.Quantity;
+ orderItem.OpenQty = itemModel.Quantity;
+
+ if (orderItem.UnitPriceExclTax != itemModel.UnitPriceExclTaxValue)
+ {
+ orderItem.UnitPriceExclTax = itemModel.UnitPriceExclTaxValue;
+ orderItem.UnitPriceInclTax =
+ Math.Round(orderItem.UnitPriceExclTax * orderItem.TaxRate / 100 + orderItem.UnitPriceExclTax, 2);
+ orderItem.PriceInclTax = Math.Round(orderItem.UnitPriceInclTax * orderItem.Quantity, 2);
+ orderItem.PriceExclTax = Math.Round(orderItem.UnitPriceExclTax * orderItem.Quantity, 2);
+ orderItem.DiscountAmountInclTax = 0;
+ orderItem.DiscountAmountExclTax = 0;
+ }
+ else
+ {
+ orderItem.PriceInclTax = Math.Round(orderItem.UnitPriceInclTax * orderItem.Quantity, 2);
+ orderItem.PriceExclTax = Math.Round(orderItem.UnitPriceExclTax * orderItem.Quantity, 2);
+ orderItem.DiscountAmountInclTax = 0;
+ orderItem.DiscountAmountExclTax = 0;
+ }
+
+ await mediator.Send(new UpdateOrderItemCommand { Order = order, OrderItem = orderItem });
+ await SaveSelectedTabIndex(persistForTheNextRequest: true);
+ return RedirectToAction("Edit", "Order", new { id });
+ }
+
+ [PermissionAuthorizeAction(PermissionActionName.Edit)]
+ [HttpPost]
+ public async Task<IActionResult> DeleteOrderItem(string id, string orderItemId)
+ {
+ var (order, denied) = await LoadAuthorizedOrder(id);
+ if (denied != null) return denied;
+
+ var orderItem = order.OrderItems.FirstOrDefault(x => x.Id == orderItemId)
+ ?? throw new ArgumentException("No order item found with the specified id");
+ var result = await mediator.Send(new DeleteOrderItemCommand { Order = order, OrderItem = orderItem });
+ if (result.error) Error(result.message);
+
+ await SaveSelectedTabIndex(persistForTheNextRequest: true);
+ return RedirectToAction("Edit", "Order", new { id });
+ }
+
+ [PermissionAuthorizeAction(PermissionActionName.Edit)]
+ [HttpPost]
+ public async Task<IActionResult> CancelOrderItem(string id, string orderItemId)
+ {
+ var (order, denied) = await LoadAuthorizedOrder(id);
+ if (denied != null) return denied;
+
+ var orderItem = order.OrderItems.FirstOrDefault(x => x.Id == orderItemId)
+ ?? throw new ArgumentException("No order item found with the specified id");
+ var result = await mediator.Send(new CancelOrderItemCommand { Order = order, OrderItem = orderItem });
+ if (result.error) Error(result.message);
+ else Success("The order item was successfully canceled");
+
+ await SaveSelectedTabIndex(persistForTheNextRequest: true);
+ return RedirectToAction("Edit", "Order", new { id });
+ }
+
+ [PermissionAuthorizeAction(PermissionActionName.Edit)]
+ [HttpPost]
+ public async Task<IActionResult> ResetDownloadCount(string id, string orderItemId)
+ {
+ var (order, denied) = await LoadAuthorizedOrder(id);
+ if (denied != null) return denied;
+
+ var orderItem = order.OrderItems.FirstOrDefault(x => x.Id == orderItemId)
+ ?? throw new ArgumentException("No order item found with the specified id");
+ orderItem.DownloadCount = 0;
+ await orderService.UpdateOrder(order);
+ var model = new OrderModel();
+ await orderViewModelService.PrepareOrderDetailsModel(model, order);
+
+ await SaveSelectedTabIndex(persistForTheNextRequest: true);
+ return RedirectToAction("Edit", "Order", new { id });
+ }
+
+ [PermissionAuthorizeAction(PermissionActionName.Edit)]
+ [HttpPost]
+ public async Task<IActionResult> ActivateDownloadItem(string id, string orderItemId)
+ {
+ var (order, denied) = await LoadAuthorizedOrder(id);
+ if (denied != null) return denied;
+
+ var orderItem = order.OrderItems.FirstOrDefault(x => x.Id == orderItemId)
+ ?? throw new ArgumentException("No order item found with the specified id");
+ orderItem.IsDownloadActivated = !orderItem.IsDownloadActivated;
+ await orderService.UpdateOrder(order);
+ var model = new OrderModel();
+ await orderViewModelService.PrepareOrderDetailsModel(model, order);
+
+ await SaveSelectedTabIndex(persistForTheNextRequest: true);
+ return RedirectToAction("Edit", "Order", new { id });
+ }
+
+ #endregion
}