A native macOS / windows / Linux database IDE built with Swift and AppKit. Connect to PostgreSQL, MySQL, SQLite, and Redis from a single app with a fast, keyboard-driven interface.
C++
fix(postgres): decode array result cells
Tobi26553565b1c0
diff --git a/macos/Data/Adapters/PostgreSQL/PostgreSQLAdapter.swift b/macos/Data/Adapters/PostgreSQL/PostgreSQLAdapter.swiftindex 8634491..54b3a12 100644--- a/macos/Data/Adapters/PostgreSQL/PostgreSQLAdapter.swift+++ b/macos/Data/Adapters/PostgreSQL/PostgreSQLAdapter.swift@@ -865,6 +865,22 @@ final class PostgreSQLAdapter: DatabaseAdapter, SchemaInspectable, @unchecked Sereturn .uuid(try cell.decode(UUID.self))case .json, .jsonb:return .json(try cell.decode(String.self))+ case .textArray, .varcharArray, .bpcharArray, .nameArray:+ return .array(try cell.decode([String].self).map { .string($0) })+ case .boolArray:+ return .array(try cell.decode([Bool].self).map { .boolean($0) })+ case .int2Array:+ return .array(try cell.decode([Int16].self).map { .integer(Int64($0)) })+ case .int4Array:+ return .array(try cell.decode([Int32].self).map { .integer(Int64($0)) })+ case .int8Array:+ return .array(try cell.decode([Int64].self).map { .integer($0) })+ case .float4Array:+ return .array(try cell.decode([Float].self).map { .double(Double($0)) })+ case .float8Array:+ return .array(try cell.decode([Double].self).map { .double($0) })+ case .uuidArray:+ return .array(try cell.decode([UUID].self).map { .uuid($0) })default:// Try String decoding, but validate it's not binary garbageif let s = try? cell.decode(String.self),diff --git a/macos/Tests/GridexTests/PostgreSQLAdapterIntegrationTests.swift b/macos/Tests/GridexTests/PostgreSQLAdapterIntegrationTests.swiftindex e2a92bd..bf8025a 100644--- a/macos/Tests/GridexTests/PostgreSQLAdapterIntegrationTests.swift+++ b/macos/Tests/GridexTests/PostgreSQLAdapterIntegrationTests.swift@@ -307,6 +307,52 @@ final class PostgreSQLAdapterIntegrationTests: XCTestCase {try await adapter.disconnect()}+ // MARK: - Issue #75 - PostgreSQL array cells must not render as NULL++ func test_execute_decodesTextArrayCells() async throws {+ try skipIfNoServer(port: 55434)++ let cfg = makeBaseConfig(host: "127.0.0.1", port: 55434, sslMode: .disabled)+ let adapter = PostgreSQLAdapter()+ try await adapter.connect(config: cfg, password: nil)++ let table = "gridex_array_test_\(UUID().uuidString.prefix(8).lowercased())"+ do {+ _ = try await adapter.executeRaw(sql: "CREATE TEMP TABLE \(table) (id int, reasons text[])")+ _ = try await adapter.executeRaw(sql: """+ INSERT INTO \(table) VALUES+ (1, ARRAY['because', 'why']::text[]),+ (2, NULL),+ (3, ARRAY[]::text[])+ """)++ let result = try await adapter.executeRaw(sql: "SELECT reasons FROM \(table) ORDER BY id")++ XCTAssertEqual(result.rows.count, 3)+ XCTAssertEqual(result.columns.first?.dataType, "TEXT[]")++ guard case .array(let reasons) = result.rows[0][0] else {+ XCTFail("Expected non-null text[] to decode as RowValue.array")+ try? await adapter.disconnect()+ return+ }+ XCTAssertEqual(reasons, [.string("because"), .string("why")])+ XCTAssertEqual(result.rows[1][0], .null)++ guard case .array(let emptyReasons) = result.rows[2][0] else {+ XCTFail("Expected empty text[] to decode as an empty RowValue.array")+ try? await adapter.disconnect()+ return+ }+ XCTAssertTrue(emptyReasons.isEmpty)+ } catch {+ try? await adapter.disconnect()+ throw error+ }++ try await adapter.disconnect()+ }+// MARK: - Issue #49 — Explain button server-side regression// The query editor button used to send "EXPLAIN QUERY PLAN <sql>" to every