Skip to content

A native macOS / windows / Linux database IDE built with Swift and AppKit. Connect to PostgreSQL, MySQL, SQLite, and Redis from a single app with a fast, keyboard-driven interface.

C++

test(redis): cover late browser request completions

Tobi66defecb658b
diff --git a/macos/Tests/GridexTests/RedisKeyBrowserViewStateTests.swift b/macos/Tests/GridexTests/RedisKeyBrowserViewStateTests.swift
index ca54830..94b3f39 100644
--- a/macos/Tests/GridexTests/RedisKeyBrowserViewStateTests.swift
+++ b/macos/Tests/GridexTests/RedisKeyBrowserViewStateTests.swift
@@ -107,6 +107,87 @@ final class RedisKeyBrowserViewStateTests: XCTestCase {
XCTAssertNil(state.visibleErrorMessage(in: context))
}
+ func test_olderSuccessCompletingLastCannotReplaceNewerFailure() async {
+ let state = RedisKeyBrowserViewState()
+ let context = redisContext()
+ let olderGate = RedisOwnershipTestGate()
+
+ await state.scan(in: context) {
+ Optional<Result<RedisKeyScanResult, Error>>.some(
+ .success(RedisKeyScanResult(
+ keys: ["retained:key"],
+ isTruncated: false
+ ))
+ )
+ }
+
+ let olderScan = Task { @MainActor in
+ await state.scan(in: context) {
+ await olderGate.enterAndWait()
+ return Optional<Result<RedisKeyScanResult, Error>>.some(
+ .success(RedisKeyScanResult(
+ keys: ["obsolete:key"],
+ isTruncated: false
+ ))
+ )
+ }
+ }
+ await olderGate.waitUntilEntered()
+
+ await state.scan(in: context) {
+ Optional<Result<RedisKeyScanResult, Error>>.some(
+ .failure(ExpectedBrowserScanError.failed)
+ )
+ }
+
+ XCTAssertFalse(state.isLoading)
+ XCTAssertEqual(state.visibleResult(in: context)?.keys, ["retained:key"])
+ XCTAssertEqual(state.visibleErrorMessage(in: context), "scan failed")
+
+ await olderGate.release()
+ await olderScan.value
+
+ XCTAssertFalse(state.isLoading)
+ XCTAssertEqual(state.visibleResult(in: context)?.keys, ["retained:key"])
+ XCTAssertEqual(state.visibleErrorMessage(in: context), "scan failed")
+ }
+
+ func test_olderFailureCompletingLastCannotReplaceNewerSuccess() async {
+ let state = RedisKeyBrowserViewState()
+ let context = redisContext()
+ let olderGate = RedisOwnershipTestGate()
+
+ let olderScan = Task { @MainActor in
+ await state.scan(in: context) {
+ await olderGate.enterAndWait()
+ return Optional<Result<RedisKeyScanResult, Error>>.some(
+ .failure(ExpectedBrowserScanError.obsolete)
+ )
+ }
+ }
+ await olderGate.waitUntilEntered()
+
+ await state.scan(in: context) {
+ Optional<Result<RedisKeyScanResult, Error>>.some(
+ .success(RedisKeyScanResult(
+ keys: ["current:key"],
+ isTruncated: false
+ ))
+ )
+ }
+
+ XCTAssertFalse(state.isLoading)
+ XCTAssertEqual(state.visibleResult(in: context)?.keys, ["current:key"])
+ XCTAssertNil(state.visibleErrorMessage(in: context))
+
+ await olderGate.release()
+ await olderScan.value
+
+ XCTAssertFalse(state.isLoading)
+ XCTAssertEqual(state.visibleResult(in: context)?.keys, ["current:key"])
+ XCTAssertNil(state.visibleErrorMessage(in: context))
+ }
+
func test_currentStaleScanStopsLoadingWithoutPublishingContent() async {
let state = RedisKeyBrowserViewState()
let context = redisContext()
@@ -179,8 +260,14 @@ final class RedisKeyBrowserViewStateTests: XCTestCase {
private enum ExpectedBrowserScanError: LocalizedError {
case failed
+ case obsolete
var errorDescription: String? {
- "scan failed"
+ switch self {
+ case .failed:
+ "scan failed"
+ case .obsolete:
+ "obsolete scan failed"
+ }
}
}
diff --git a/macos/Tests/GridexTests/RedisRequestCoordinatorTests.swift b/macos/Tests/GridexTests/RedisRequestCoordinatorTests.swift
index 7d23a3f..4d88340 100644
--- a/macos/Tests/GridexTests/RedisRequestCoordinatorTests.swift
+++ b/macos/Tests/GridexTests/RedisRequestCoordinatorTests.swift
@@ -44,6 +44,70 @@ final class RedisRequestCoordinatorTests: XCTestCase {
}
}
+ func test_olderSuccessIsSupersededAfterNewerRequestAlreadyCompleted() async {
+ let coordinator = RedisRequestCoordinator()
+ let context = redisContext()
+ let olderGate = RedisOwnershipTestGate()
+
+ let olderRequest = Task { @MainActor in
+ await coordinator.perform(for: context) {
+ await olderGate.enterAndWait()
+ return Optional<Result<String, Error>>.some(.success("obsolete"))
+ }
+ }
+ await olderGate.waitUntilEntered()
+
+ let newerCompletion = await coordinator.perform(for: context) {
+ Optional<Result<String, Error>>.some(.success("current"))
+ }
+ guard case .current(.success(let value)) = newerCompletion else {
+ return XCTFail("Expected the newer success to remain current")
+ }
+ XCTAssertEqual(value, "current")
+
+ await olderGate.release()
+ let olderCompletion = await olderRequest.value
+
+ guard case .superseded = olderCompletion else {
+ return XCTFail(
+ "An older success must stay superseded after the newer request completes"
+ )
+ }
+ }
+
+ func test_olderFailureIsSupersededAfterNewerRequestAlreadyCompleted() async {
+ let coordinator = RedisRequestCoordinator()
+ let context = redisContext()
+ let olderGate = RedisOwnershipTestGate()
+
+ let olderRequest = Task { @MainActor in
+ await coordinator.perform(for: context) {
+ await olderGate.enterAndWait()
+ return Optional<Result<String, Error>>.some(
+ .failure(ExpectedRequestError.failed)
+ )
+ }
+ }
+ await olderGate.waitUntilEntered()
+
+ let newerCompletion = await coordinator.perform(for: context) {
+ Optional<Result<String, Error>>.some(.success("current"))
+ }
+ guard case .current(.success(let value)) = newerCompletion else {
+ return XCTFail("Expected the newer success to remain current")
+ }
+ XCTAssertEqual(value, "current")
+
+ await olderGate.release()
+ let olderCompletion = await olderRequest.value
+
+ guard case .superseded = olderCompletion else {
+ return XCTFail(
+ "An older failure must stay superseded after the newer request completes"
+ )
+ }
+ }
+
func test_currentSuccessIsReturnedAsCurrent() async {
let coordinator = RedisRequestCoordinator()