Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix: another test re-enabled after adding conjunctions to the disambig

hippietrail0097bb0f368b
diff --git a/harper-core/src/linting/lets_confusion/no_contraction_with_verb.rs b/harper-core/src/linting/lets_confusion/no_contraction_with_verb.rs
index ed7224afd..276faa6bd 100644
--- a/harper-core/src/linting/lets_confusion/no_contraction_with_verb.rs
+++ b/harper-core/src/linting/lets_confusion/no_contraction_with_verb.rs
@@ -54,7 +54,7 @@ impl Default for NoContractionWithVerb {
.then(|tok: &Token, _source: &[char]| tok.kind.is_verb() || tok.kind.is_noun())
.then_whitespace()
.then(|tok: &Token, _source: &[char]| {
- tok.kind.is_determiner() || tok.kind.is_pronoun()
+ tok.kind.is_determiner() || tok.kind.is_pronoun() || tok.kind.is_conjunction()
});
let let_then_verb = let_ws.then(EitherPattern::new(vec![
diff --git a/harper-core/tests/run_tests.rs b/harper-core/tests/run_tests.rs
index 521fd5a99..5a3729153 100644
--- a/harper-core/tests/run_tests.rs
+++ b/harper-core/tests/run_tests.rs
@@ -48,8 +48,7 @@ create_test!(issue_195.md, 0, Dialect::American);
create_test!(issue_118.md, 0, Dialect::American);
create_test!(lots_of_latin.md, 0, Dialect::American);
create_test!(pr_504.md, 1, Dialect::American);
-// 452.md is based on a verb which is also a noun, breaking a heuristic that detects false positives
-//create_test!(pr_452.md, 2, Dialect::American);
+create_test!(pr_452.md, 2, Dialect::American);
create_test!(hex_basic_clean.md, 0, Dialect::American);
create_test!(hex_basic_dirty.md, 1, Dialect::American);
create_test!(misc_closed_compound_clean.md, 0, Dialect::American);