Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

feat: environmental variable→environment variable (#3537)

Andrew Dunbar02fcba21a4d1
diff --git a/harper-core/default_config.json b/harper-core/default_config.json
index 07ac4d3ab..a44e5aebf 100644
--- a/harper-core/default_config.json
+++ b/harper-core/default_config.json
@@ -1044,6 +1044,13 @@
"label": "Operating System"
}
},
+ {
+ "Bool": {
+ "name": "EnvironmentVariable",
+ "state": true,
+ "label": "Environment Variable"
+ }
+ },
{
"Bool": {
"name": "PassersBy",
diff --git a/harper-core/src/linting/weir_rules/EnvironmentVariable/Plural.weir b/harper-core/src/linting/weir_rules/EnvironmentVariable/Plural.weir
new file mode 100644
index 000000000..a9373ac51
--- /dev/null
+++ b/harper-core/src/linting/weir_rules/EnvironmentVariable/Plural.weir
@@ -0,0 +1,8 @@
+expr main (environmental variables)
+
+let message "Did you mean `environment variables`?"
+let description "Ensures `environment variables` is used correctly instead of `environmental variables`."
+let kind "Usage"
+let becomes "environment variables"
+
+test "If environmental variables are case sensitive, the case should be preserved, even in sub-tasks" "If environment variables are case sensitive, the case should be preserved, even in sub-tasks"
diff --git a/harper-core/src/linting/weir_rules/EnvironmentVariable/PluralAbbreviation.weir b/harper-core/src/linting/weir_rules/EnvironmentVariable/PluralAbbreviation.weir
new file mode 100644
index 000000000..21a71b6e5
--- /dev/null
+++ b/harper-core/src/linting/weir_rules/EnvironmentVariable/PluralAbbreviation.weir
@@ -0,0 +1,8 @@
+expr main (environmental vars)
+
+let message "Did you mean `environment vars`?"
+let description "Ensures `environment vars` is used correctly instead of `environmental vars`."
+let kind "Usage"
+let becomes "environment vars"
+
+test "environmental vars are ignored if an experimental setting is set" "environment vars are ignored if an experimental setting is set"
diff --git a/harper-core/src/linting/weir_rules/EnvironmentVariable/Singular.weir b/harper-core/src/linting/weir_rules/EnvironmentVariable/Singular.weir
new file mode 100644
index 000000000..141b075ba
--- /dev/null
+++ b/harper-core/src/linting/weir_rules/EnvironmentVariable/Singular.weir
@@ -0,0 +1,8 @@
+expr main (environmental variable)
+
+let message "Did you mean `environment variable`?"
+let description "Ensures `environment variable` is used correctly instead of `environmental variable`."
+let kind "Usage"
+let becomes "environment variable"
+
+test "Specifically, any Service I have injects an environmental variable like MYSERVICE_PORT=tcp://1.2.3.4:5." "Specifically, any Service I have injects an environment variable like MYSERVICE_PORT=tcp://1.2.3.4:5."
diff --git a/harper-core/src/linting/weir_rules/EnvironmentVariable/SingularAbbreviation.weir b/harper-core/src/linting/weir_rules/EnvironmentVariable/SingularAbbreviation.weir
new file mode 100644
index 000000000..71d3b1595
--- /dev/null
+++ b/harper-core/src/linting/weir_rules/EnvironmentVariable/SingularAbbreviation.weir
@@ -0,0 +1,8 @@
+expr main (environmental var)
+
+let message "Did you mean `environment var`?"
+let description "Ensures `environment var` is used correctly instead of `environmental var`."
+let kind "Usage"
+let becomes "environment var"
+
+test "I'm loading dev with the following auto-reloading command and environmental var at the beginning for now." "I'm loading dev with the following auto-reloading command and environment var at the beginning for now."