Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix: missing static analysis from some projects (#4451)

Elijah Potter07ecdf583bab
diff --git a/justfile b/justfile
index b47fccec3..6665903dd 100644
--- a/justfile
+++ b/justfile
@@ -475,7 +475,15 @@ check-js: build-harperjs build-lint-framework build-components build-harper-edit
pnpm install
pnpm check
- # Needed because Svelte has special linters
+ cd "{{justfile_directory()}}/packages/chrome-plugin"
+ pnpm check
+
+ cd "{{justfile_directory()}}/packages/components"
+ pnpm check
+
+ cd "{{justfile_directory()}}/packages/harper-editor"
+ pnpm check
+
cd "{{justfile_directory()}}/packages/web"
ENABLE_ADMIN_ROUTES=false pnpm check
diff --git a/packages/chrome-plugin/package.json b/packages/chrome-plugin/package.json
index cb616f8ad..b414ed610 100644
--- a/packages/chrome-plugin/package.json
+++ b/packages/chrome-plugin/package.json
@@ -18,6 +18,10 @@
"scripts": {
"dev": "vite",
"build": "vite build -l warn",
+ "check": "pnpm check:typescript && pnpm check:config && pnpm check:svelte",
+ "check:typescript": "tsc --noEmit --project tsconfig.json",
+ "check:config": "tsc --noEmit --project tsconfig.node.json",
+ "check:svelte": "svelte-check --tsconfig ./tsconfig.json",
"preview": "vite preview",
"zip-for-chrome": "TARGET_BROWSER=chrome npm run build && node src/zip.js harper-chrome-plugin.zip",
"zip-for-firefox": "TARGET_BROWSER=firefox npm run build && node src/zip.js harper-firefox-plugin.zip",
@@ -39,6 +43,7 @@
"playwright-webextext": "^0.0.5",
"rollup-plugin-copy": "^3.5.0",
"svelte": "^5.0.0",
+ "svelte-check": "^4.3.3",
"svelte-preprocess": "^6.0.0",
"tailwindcss": "^4.1.4",
"tslib": "^2.6.2",
diff --git a/packages/chrome-plugin/src/background/index.ts b/packages/chrome-plugin/src/background/index.ts
index 9274700f5..e28f54a32 100644
--- a/packages/chrome-plugin/src/background/index.ts
+++ b/packages/chrome-plugin/src/background/index.ts
@@ -434,7 +434,7 @@ async function handleGetDefaultStatus(): Promise<GetDefaultStatusResponse> {
}
async function handleGetEnabledDomains(): Promise<GetEnabledDomainsResponse> {
- const all = await chrome.storage.local.get(null as any);
+ const all = await chrome.storage.local.get(null);
const prefix = formatDomainKey(''); // yields 'domainStatus '
const domains = Object.entries(all)
.filter(([k, v]) => typeof v === 'boolean' && v === true && k.startsWith(prefix))
@@ -525,6 +525,8 @@ async function handleSetHotkey(req: SetHotkeyRequest): Promise<UnitResponse> {
key: req.hotkey.key,
};
await setHotkey(hotkey);
+
+ return createUnitResponse();
}
async function handleOpenReportError(
@@ -788,7 +790,7 @@ async function getStoredDomainStatus(domain: string): Promise<boolean | undefine
}
/** Check if Harper has been enabled for a given domain. */
-async function enabledForDomain(domain: string): Promise<boolean | null> {
+async function enabledForDomain(domain: string): Promise<boolean> {
const stored = await getStoredDomainStatus(domain);
if (stored !== undefined) {
return stored;
diff --git a/packages/chrome-plugin/src/manifest.ts b/packages/chrome-plugin/src/manifest.ts
index c754c57a3..d95b83fb8 100644
--- a/packages/chrome-plugin/src/manifest.ts
+++ b/packages/chrome-plugin/src/manifest.ts
@@ -1,7 +1,6 @@
import { defineManifest } from '@crxjs/vite-plugin';
import packageData from '../package.json';
-//@ts-expect-error
const isDev = process.env.NODE_ENV == 'development';
/**
@@ -70,6 +69,8 @@ export default defineManifest({
matches: ['<all_urls>'],
all_frames: true,
match_about_blank: true,
+ // CRXJS's manifest types do not include this Chromium manifest option.
+ // @ts-expect-error Valid for Manifest V3 content scripts.
match_origin_as_fallback: true,
js: ['src/contentScript/index.ts'],
run_at: 'document_idle',
diff --git a/packages/chrome-plugin/src/options/StructuredRuleSettings.svelte b/packages/chrome-plugin/src/options/StructuredRuleSettings.svelte
index 42c5faf1d..4b8d04e30 100644
--- a/packages/chrome-plugin/src/options/StructuredRuleSettings.svelte
+++ b/packages/chrome-plugin/src/options/StructuredRuleSettings.svelte
@@ -67,7 +67,7 @@ function configValueToString(value: boolean | undefined | null): string {
}
}
-function configStringToValue(str: string): boolean | undefined | null {
+function configStringToValue(str: string): boolean | null {
switch (str) {
case 'enable':
return true;
@@ -327,7 +327,7 @@ $: {
size="md"
title={`Set all rules in the ${node.label} category to their default, on, or off state.`}
value={node.state === 'mixed' ? 'default' : node.state}
- onchange={(event) => updateGroup(node.ruleNames, (event.target as HTMLSelectElement).value)}
+ onchange={(event: Event) => updateGroup(node.ruleNames, (event.target as HTMLSelectElement).value)}
>
<option value="default">{node.state === 'mixed' ? '⚙️ Default (mixed)' : '⚙️ Default'}</option>
<option value="enable">✅ On</option>
@@ -362,7 +362,7 @@ $: {
size="md"
title={node.title}
value={node.value}
- onchange={(event) => {
+ onchange={(event: Event) => {
const nextConfig: LintConfig = { ...lintConfig };
nextConfig[node.name] = configStringToValue(
(event.target as HTMLSelectElement).value,
@@ -384,7 +384,7 @@ $: {
size="md"
title={node.title}
value={node.value}
- onchange={(event) => updateOneOfMany(node.setting, (event.target as HTMLSelectElement).value)}
+ onchange={(event: Event) => updateOneOfMany(node.setting, (event.target as HTMLSelectElement).value)}
>
{#each node.options as option}
<option value={option.value}>{option.label}</option>
diff --git a/packages/chrome-plugin/src/popup/Popup.svelte b/packages/chrome-plugin/src/popup/Popup.svelte
index 83d2b92ed..a9844c4ac 100644
--- a/packages/chrome-plugin/src/popup/Popup.svelte
+++ b/packages/chrome-plugin/src/popup/Popup.svelte
@@ -71,12 +71,12 @@ function openUpdateHelpPage() {
popupState = main();
}}><Fa icon={faArrowLeft}/></Button>
{:else}
- <div onclick={openUpdateHelpPage}>
+ <button type="button" class="cursor-pointer" onclick={openUpdateHelpPage}>
{#if versionMismatch}
<span class="ml-1" title={`Newer version available: ${latestVersion ?? ''}. Click to find out more.`}>⚠️</span>
{/if}
<span class="text-sm font-mono">{version}</span>
- </div>
+ </button>
{/if}
</header>
diff --git a/packages/chrome-plugin/src/theme.ts b/packages/chrome-plugin/src/theme.ts
index 57c61593a..78e1bee96 100644
--- a/packages/chrome-plugin/src/theme.ts
+++ b/packages/chrome-plugin/src/theme.ts
@@ -21,9 +21,5 @@ export function setupTheme() {
applyDarkTheme(event.matches);
};
- if ('addEventListener' in mediaQuery) {
- mediaQuery.addEventListener('change', listener);
- } else {
- mediaQuery.addListener(listener);
- }
+ mediaQuery.addEventListener('change', listener);
}
diff --git a/packages/chrome-plugin/tsconfig.json b/packages/chrome-plugin/tsconfig.json
index e254bd39d..09099555a 100644
--- a/packages/chrome-plugin/tsconfig.json
+++ b/packages/chrome-plugin/tsconfig.json
@@ -11,16 +11,11 @@
"strict": true,
"forceConsistentCasingInFileNames": true,
"module": "ESNext",
- "moduleResolution": "Node",
+ "moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
"jsx": "react-jsx"
},
- "include": ["src"],
- "references": [
- {
- "path": "./tsconfig.node.json"
- }
- ]
+ "include": ["src"]
}
diff --git a/packages/chrome-plugin/tsconfig.node.json b/packages/chrome-plugin/tsconfig.node.json
index 73a2040d8..b0bf7ed56 100644
--- a/packages/chrome-plugin/tsconfig.node.json
+++ b/packages/chrome-plugin/tsconfig.node.json
@@ -1,8 +1,11 @@
{
"compilerOptions": {
- "composite": true,
+ "target": "ESNext",
"module": "ESNext",
- "moduleResolution": "Node"
+ "moduleResolution": "bundler",
+ "allowSyntheticDefaultImports": true,
+ "resolveJsonModule": true,
+ "skipLibCheck": true
},
- "include": ["vite.config.ts"]
+ "include": ["vite.config.ts", "src/manifest.ts"]
}
diff --git a/packages/chrome-plugin/vite.config.ts b/packages/chrome-plugin/vite.config.ts
index 79c418b33..87373e804 100644
--- a/packages/chrome-plugin/vite.config.ts
+++ b/packages/chrome-plugin/vite.config.ts
@@ -4,7 +4,7 @@ import tailwindcss from '@tailwindcss/vite';
import path from 'path';
import copy from 'rollup-plugin-copy';
import sveltePreprocess from 'svelte-preprocess';
-import { defineConfig, loadEnv } from 'vite';
+import { defineConfig, loadEnv, type PluginOption } from 'vite';
import manifest from './src/manifest';
export default defineConfig(({ mode }) => {
@@ -12,7 +12,7 @@ export default defineConfig(({ mode }) => {
const browser = env.TARGET_BROWSER ?? 'chrome';
- if (!['chrome', 'firefox'].includes(browser)) {
+ if (browser !== 'chrome' && browser !== 'firefox') {
throw new Error('UNSUPPORTED BROWSER TYPE');
}
@@ -39,9 +39,9 @@ export default defineConfig(({ mode }) => {
dest: './public/wasm',
},
],
- }),
+ }) as unknown as PluginOption,
tailwindcss(),
- crx({ manifest, browser }),
+ crx({ manifest, browser }) as unknown as PluginOption,
svelte({
compilerOptions: {
dev: !production,
diff --git a/packages/harper-editor/src/lib/editorDisplay.ts b/packages/harper-editor/src/lib/editorDisplay.ts
index 5806b6a90..03e4932d5 100644
--- a/packages/harper-editor/src/lib/editorDisplay.ts
+++ b/packages/harper-editor/src/lib/editorDisplay.ts
@@ -56,6 +56,7 @@ export const LINT_KIND_ORDER: LintKind[] = [
'Punctuation',
'Usage',
'WordChoice',
+ 'WordOrder',
'Style',
'Readability',
'Enhancement',
@@ -247,6 +248,14 @@ export const LINT_KIND_STYLES: Record<
softClass: 'bg-blue-50',
activeClass: 'border-[rgba(28,26,22,0.14)] shadow-blue-600/10',
},
+ WordOrder: {
+ label: 'Word Order',
+ dotClass: 'bg-indigo-600',
+ haloClass: 'bg-indigo-100',
+ textClass: 'text-indigo-700',
+ softClass: 'bg-indigo-50',
+ activeClass: 'border-[rgba(28,26,22,0.14)] shadow-indigo-600/10',
+ },
};
export const LINT_KIND_STYLE_ENTRIES = LINT_KIND_ORDER.map(
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index c1c05321e..91b23cbb0 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -171,6 +171,9 @@ importers:
svelte:
specifier: ^5.0.0
version: 5.43.12
+ svelte-check:
+ specifier: ^4.3.3
svelte-preprocess:
specifier: ^6.0.0