Offline, privacy-first grammar checker. Fast, open-source, Rust-powered
fix: false positives after object case pronouns (#1353)
Andrew Dunbar12e41304e047
diff --git a/harper-core/src/linting/nominal_wants.rs b/harper-core/src/linting/nominal_wants.rsindex 5dcee5280..ac254c1cc 100644--- a/harper-core/src/linting/nominal_wants.rs+++ b/harper-core/src/linting/nominal_wants.rs@@ -11,13 +11,26 @@ pub struct NominalWants {impl Default for NominalWants {fn default() -> Self {- // "That" can act as two kinds of pronoun: demonstrative and relative.- // As a demonstrative pronoun, it's third person singular.- // As a relative pronoun, it's behaves as any person:- // I am the one that wants to. He is the one that wants to.fn is_applicable_pronoun(tok: &Token, src: &[char]) -> bool {if tok.kind.is_pronoun() {- tok.span.get_content_string(src).to_lowercase() != "that"+ let pron = tok.span.get_content_string(src).to_lowercase();+ // "That" can act as two kinds of pronoun: demonstrative and relative.+ // As a demonstrative pronoun, it's third person singular.+ // As a relative pronoun, it's behaves as any person:+ // I am the one that wants to. He is the one that wants to.+ pron != "that"+ // Personal pronouns have case. Object case personal pronouns+ // can come after "want":+ // Make them want to believe.+ // Note: "you" and "it" are both subject and object case.+ && pron != "me"+ && pron != "us"+ // "you" is subject and object both OK before "want".+ && pron != "him"+ && pron != "her"+ // "it" is both subject and object. Subject before "wants", object before "want".+ && pron != "it"+ && pron != "them"} else {false}@@ -96,6 +109,7 @@ mod tests {}#[test]+ #[ignore = "This is not a grammar error if the previous word is `help`, `let`, or `make`."]fn fixes_it_wont() {assert_suggestion_result("It wont to move forward.",@@ -154,4 +168,131 @@ mod tests {0,);}++ #[test]+ fn ignores_correct_usage_make_me() {+ assert_lint_count(+ "Take another person code make me want to die.",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_makes_me() {+ assert_lint_count(+ "It makes me want to not use GitHub at all.",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_make_us() {+ assert_lint_count(+ "... try harder to make us want to implement it.",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_made_us() {+ assert_lint_count(+ "This change made us want to adopt luxon's strict mode",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_help_us() {+ assert_lint_count("... help us want to help you.", NominalWants::default(), 0);+ }++ #[test]+ fn ignores_correct_usage_make_you() {+ assert_lint_count(+ "I can certainly see why that would make you want to ditch Linux packaging.",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_makes_you() {+ assert_lint_count(+ "If something happens that makes you want to scream from the top of your lungs",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_made_you() {+ assert_lint_count(+ "What made you want to leave the LibFuzzer ...",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_make_him() {+ assert_lint_count(+ "make him want to help with your issue",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_make_her() {+ assert_lint_count(+ "... and make her want to get into coding.",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_make_it() {+ assert_lint_count(+ "you just make it want to appear as a drama",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_makes_it() {+ assert_lint_count(+ "using UHD makes it want to put labels in the corner saying UHD",+ NominalWants::default(),+ 0,+ );+ }++ #[test]+ fn ignores_correct_usage_make_them() {+ assert_lint_count(+ "And make them want to believe in it.",+ NominalWants::default(),+ 0,+ )+ }++ #[test]+ fn ignores_correct_usage_making_them() {+ assert_lint_count(+ "you're annoying ALMOST ALL of the users and making them want to switch to another ...",+ NominalWants::default(),+ 0,+ )+ }++ #[test]+ fn ignores_correct_usage_help_them() {+ assert_lint_count("And help them want to do it.", NominalWants::default(), 0)+ }}