Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

feat(vscode-plugin): notify harper-ls of config change instead of restarting it

Matthew Espino1e6dfbc615a0
diff --git a/packages/vscode-plugin/src/extension.ts b/packages/vscode-plugin/src/extension.ts
index 7396aacdc..3fe4a5a75 100644
--- a/packages/vscode-plugin/src/extension.ts
+++ b/packages/vscode-plugin/src/extension.ts
@@ -44,8 +44,9 @@ export async function activate(context: ExtensionContext): Promise<void> {
context.subscriptions.push(
workspace.onDidChangeConfiguration(async (event) => {
if (configs.find((c) => event.affectsConfiguration(c))) {
- clientOptions.outputChannel?.appendLine('Configuration changed, restarting server');
- await startLanguageServer();
+ await client?.sendNotification('workspace/didChangeConfiguration', {
+ settings: { 'harper-ls': workspace.getConfiguration('harper-ls') }
+ });
}
})
);
diff --git a/packages/vscode-plugin/src/tests/suite/integration.test.ts b/packages/vscode-plugin/src/tests/suite/integration.test.ts
index 594752306..2ae9b3de5 100644
--- a/packages/vscode-plugin/src/tests/suite/integration.test.ts
+++ b/packages/vscode-plugin/src/tests/suite/integration.test.ts
@@ -47,8 +47,8 @@ describe('Integration >', () => {
it('updates diagnostics on configuration change', async () => {
const config = workspace.getConfiguration('harper-ls.linters');
await config.update('repeated_words', false, ConfigurationTarget.Workspace);
- // Wait for `harper-ls` to restart and send new diagnostics
- await sleep(1000);
+ // Wait for `harper-ls` to update diagnostics
+ await sleep(200);
compareActualVsExpectedDiagnostics(
getActualDiagnostics(markdownUri),