Offline, privacy-first grammar checker. Fast, open-source, Rust-powered
fix: `is_possessive_nominal()` had wrong logic (#2740)
Andrew Dunbar217fe32a37b0
diff --git a/harper-core/src/dict_word_metadata.rs b/harper-core/src/dict_word_metadata.rsindex 5f4295f48..d70a1c28c 100644--- a/harper-core/src/dict_word_metadata.rs+++ b/harper-core/src/dict_word_metadata.rs@@ -610,8 +610,11 @@ impl DictWordMetadata {}/// Checks if the word is definitely a nominal and more specifically is labeled as (a) possessive.+ /// NOTE: `possessive pronoun`s are not qualifiers, but words like `mine`, `yours`, etc.+ /// The terminology of `possessive noun`, `possessive pronoun` and `possessive determiner` only+ /// tends to reinforce this confusion.pub fn is_possessive_nominal(&self) -> bool {- self.is_possessive_noun() || self.is_possessive_pronoun()+ self.is_possessive_noun() || self.is_possessive_determiner()}/// Checks if the word is definitely a nominal and more specifically is labeled as __not__ (a) singular.@@ -624,11 +627,6 @@ impl DictWordMetadata {self.is_non_plural_noun() || self.is_non_plural_pronoun()}- /// Checks if the word is definitely a nominal and more specifically is labeled as __not__ (a) possessive.- pub fn is_non_possessive_nominal(&self) -> bool {- self.is_non_possessive_noun() || self.is_non_possessive_pronoun()- }-// Adjective metadata queriespub fn get_degree(&self) -> Option<Degree> {@@ -1823,6 +1821,40 @@ pub mod tests {}}+ mod nominal {+ use crate::dict_word_metadata::tests::md;++ #[test]+ fn my_is_possessive_nominal() {+ assert!(md("my").is_possessive_nominal());+ }++ #[test]+ fn mine_is_not_possessive_nominal() {+ assert!(!md("mine").is_possessive_nominal());+ }++ #[test]+ fn freds_is_possessive_nominal() {+ assert!(md("Fred's").is_possessive_nominal());+ }++ #[test]+ fn fred_is_not_possessive_nominal() {+ assert!(!md("Fred").is_possessive_nominal());+ }++ #[test]+ fn dogs_is_possessive_nominal() {+ assert!(md("dog's").is_possessive_nominal());+ }++ #[test]+ fn microsofts_is_possessive_nominal() {+ assert!(md("Microsoft's").is_possessive_nominal());+ }+ }+mod adjective {use crate::{Degree, dict_word_metadata::tests::md};