Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

feat: every once and again→every once in a while & once again (#2361)

Andrew Dunbar31c6ecfad5b2
diff --git a/harper-core/src/linting/phrase_corrections/mod.rs b/harper-core/src/linting/phrase_corrections/mod.rs
index 67faf26b6..5743fe0d7 100644
--- a/harper-core/src/linting/phrase_corrections/mod.rs
+++ b/harper-core/src/linting/phrase_corrections/mod.rs
@@ -391,6 +391,13 @@ pub fn lint_group() -> LintGroup {
"Corrects `every since` to `ever since`.",
LintKind::Typo
),
+ "EveryOnceAndAgain" => (
+ ["every once and again"],
+ ["every once in a while", "once again"],
+ "For things that happen only occasionaly use `every once in a while. For things that persistently happen use `once again`.",
+ "Corrects `every once and again` to `every once in a while` or `once again`.",
+ LintKind::Usage
+ ),
"EveryTime" => (
["everytime"],
["every time"],
diff --git a/harper-core/src/linting/phrase_corrections/tests.rs b/harper-core/src/linting/phrase_corrections/tests.rs
index 39fb3c097..9202470aa 100644
--- a/harper-core/src/linting/phrase_corrections/tests.rs
+++ b/harper-core/src/linting/phrase_corrections/tests.rs
@@ -731,6 +731,16 @@ fn detect_ever_since() {
);
}
+// EveryOnceAndAgain
+#[test]
+fn fix_every_once_and_again() {
+ assert_suggestion_result(
+ "Ys have been replaced with Ps, happens randomly every once and again with different letters",
+ lint_group(),
+ "Ys have been replaced with Ps, happens randomly every once in a while with different letters",
+ );
+}
+
// EveryTime
#[test]
fn fix_everytime() {