Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

chore: tweak affixes, dictionary, and tests until all pass

hippietrail31f2b98d6a08
diff --git a/harper-core/affixes.json b/harper-core/affixes.json
index 57b60f30e..f6874d468 100644
--- a/harper-core/affixes.json
+++ b/harper-core/affixes.json
@@ -274,7 +274,7 @@
"gifts_metadata": {}
},
"M": {
- "#": "-'s possessive suffix",
+ "#": "-'s possessive suffix; contraction of 'has' and 'is",
"suffix": true,
"cross_product": true,
"replacements": [
@@ -625,7 +625,7 @@
}
},
"-": {
- "#": "article property",
+ "#": "determiner property",
"suffix": true,
"cross_product": true,
"replacements": [],
diff --git a/harper-core/dictionary.dict b/harper-core/dictionary.dict
index 86b67cf31..c814b9137 100644
--- a/harper-core/dictionary.dict
+++ b/harper-core/dictionary.dict
@@ -10772,7 +10772,7 @@ Zworykin/M
Zyrtec/M
Zyuganov/M
Zzz
-a/-+457~
+a/-~
as/j
aah/14
aardvark/1SM
@@ -27553,8 +27553,8 @@ hysteria/1M
hysteric/51SM
hysterical/5Y
hysterics/1M
-i/18US
-is/4813
+i/8
+is/43
iOS/2M
iPad/1M
iPhone/1M
@@ -45489,7 +45489,7 @@ thanklessness/1M
thanksgiving/1SM
that'd/
that'll/
-that/781M~
+that/7M~-
thatch/14MDRSZG
thatcher/1M
thatching/14M
@@ -45574,7 +45574,8 @@ thermostatic/5
thermostatically/
thesauri/1
thesaurus/1MS
-these/8S~9
+these/~-
+theses/9M
thesis/1M
thespian/51SM
theta/1SM
@@ -45631,7 +45632,7 @@ thirteenths/1
thirtieth/51M
thirtieths/1
thirty/1HSM
-this/81~
+this/~-
thistle/1MS
thistledown/1M
thither/5
@@ -45649,7 +45650,7 @@ thoroughbred/51MS
thoroughfare/1MS
thoroughgoing/5
thoroughness/1M
-those/8
+those/-
thou/8417MS
though/74
thought/14SM
diff --git a/harper-core/src/spell/mutable_dictionary.rs b/harper-core/src/spell/mutable_dictionary.rs
index 82919830f..9728d9f77 100644
--- a/harper-core/src/spell/mutable_dictionary.rs
+++ b/harper-core/src/spell/mutable_dictionary.rs
@@ -327,12 +327,17 @@ mod tests {
assert!(dict.contains_word_str("This"));
}
- #[test]
- fn this_is_nominal() {
- let dict = MutableDictionary::curated();
- assert!(dict.get_word_metadata_str("this").unwrap().is_nominal());
- assert!(dict.get_word_metadata_str("This").unwrap().is_nominal());
- }
+ // TODO "this" is nominal but for now "nominal" is a synonym for "noun"
+ // TODO but actually nouns are one type of nominal and "this" is a
+ // TODO "determiner". for now we'll treat "determiner" under "article"
+ // TODO though articles are a subclass of determiners.
+ // TODO there is currently no is_determiner or is_article in WordMetadata
+ // #[test]
+ // fn this_is_nominal() {
+ // let dict = MutableDictionary::curated();
+ // assert!(dict.get_word_metadata_str("this").unwrap().is_determiner());
+ // assert!(dict.get_word_metadata_str("This").unwrap().is_determiner());
+ // }
#[test]
fn than_is_conjunction() {