Offline, privacy-first grammar checker. Fast, open-source, Rust-powered
fix(core): don't push Harper version (#1775)
Elijah Potter31f6cc6054a4
diff --git a/packages/obsidian-plugin/src/HarperSettingTab.ts b/packages/obsidian-plugin/src/HarperSettingTab.tsindex cfe9cedcb..7999b477b 100644--- a/packages/obsidian-plugin/src/HarperSettingTab.ts+++ b/packages/obsidian-plugin/src/HarperSettingTab.ts@@ -115,13 +115,6 @@ export class HarperSettingTab extends PluginSettingTab {});});- new Setting(containerEl).setName('Get Notified of Harper Updates').addToggle((toggle) => {- toggle.setValue(this.settings.showUpdateNotification ?? true).onChange(async (value) => {- this.settings.showUpdateNotification = value;- await this.state.initializeFromSettings(this.settings);- });- });-new Setting(containerEl).setName('The Danger Zone').addButton((button) => {button.setButtonText('Forget Ignored Suggestions')diff --git a/packages/obsidian-plugin/src/State.ts b/packages/obsidian-plugin/src/State.tsindex 8d9bee7e9..cd73d9121 100644--- a/packages/obsidian-plugin/src/State.ts+++ b/packages/obsidian-plugin/src/State.ts@@ -14,8 +14,6 @@ export type Settings = {userDictionary?: string[];delay?: number;ignoredGlobs?: string[];- /** An undefined value should be treated the same as `true`. */- showUpdateNotification?: boolean;};const DEFAULT_DELAY = -1;@@ -30,7 +28,6 @@ export default class State {private onExtensionChange: () => void;private ignoredGlobs?: string[];private editorViewField?: StateField<MarkdownFileInfo>;- private showUpdateNotification?: boolean;/** The CodeMirror extension objects that should be inserted by the host. */private editorExtensions: Extension[];@@ -90,7 +87,6 @@ export default class State {this.delay = settings.delay ?? DEFAULT_DELAY;this.ignoredGlobs = settings.ignoredGlobs;- this.showUpdateNotification = settings.showUpdateNotification;// Reinitialize it.if (this.hasEditorLinter()) {@@ -222,7 +218,6 @@ export default class State {dialect: await this.harper.getDialect(),delay: this.delay,ignoredGlobs: this.ignoredGlobs,- showUpdateNotification: this.showUpdateNotification,};}diff --git a/packages/obsidian-plugin/src/index.ts b/packages/obsidian-plugin/src/index.tsindex 22ca2e095..4d9c8d7ed 100644--- a/packages/obsidian-plugin/src/index.ts+++ b/packages/obsidian-plugin/src/index.ts@@ -6,37 +6,6 @@ import packageJson from '../package.json';import { HarperSettingTab } from './HarperSettingTab';import State from './State';-async function getLatestVersion(): Promise<string> {- const response = await fetch('https://writewithharper.com/latestversion', {- headers: {- 'Harper-Version': packageJson.version,- },- });-- if (!response.ok) {- throw new Error(`HTTP error! status: ${response.status}`);- }-- return response.text();-}--export async function logVersionInfo(showNotification: boolean): Promise<void> {- try {- const latest = await getLatestVersion();- console.info(`Latest available Harper version: ${latest}`);-- if (latest != `v${packageJson.version}` && showNotification) {- setTimeout(() => {- new Notice('A newer version of Harper is available.');- }, 5000);- }- } catch (err) {- console.error(`Unable to obtain latest version: ${err}`);- }-- console.info(`Current version: ${packageJson.version}`);-}-export default class HarperPlugin extends Plugin {private state: State;private dialectSpan: HTMLSpanElement | null = null;@@ -65,8 +34,6 @@ export default class HarperPlugin extends Plugin {this.state.enableEditorLinter();this.addSettingTab(new HarperSettingTab(this.app, this, this.state));-- await logVersionInfo((await this.state.getSettings()).showUpdateNotification ?? true);}private getDialectStatus(dialectNum: Dialect): string {