Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

feat:make it seems→make it seem (#1609)

Andrew Dunbar35435310fc76
diff --git a/harper-core/src/linting/phrase_set_corrections/mod.rs b/harper-core/src/linting/phrase_set_corrections/mod.rs
index 6c54aab57..398219d40 100644
--- a/harper-core/src/linting/phrase_set_corrections/mod.rs
+++ b/harper-core/src/linting/phrase_set_corrections/mod.rs
@@ -286,6 +286,16 @@ pub fn lint_group() -> LintGroup {
"Corrects `how ... looks like` to `how ... looks` or `what ... looks like`.",
LintKind::Grammar
),
+ "MakeItSeem" => (
+ &[
+ (&["make it seems"], &["make it seem"]),
+ (&["made it seems", "made it seemed"], &["made it seem"]),
+ (&["makes it seems"], &["makes it seem"]),
+ (&["making it seems"], &["making it seem"]),
+ ],
+ "Don't inflect `seem` in `make it seem`.",
+ "Corrects `make it seems` to `make it seem`."
+ ),
"RiseTheQuestion" => (
&[
(&["rise the question"], &["raise the question"]),
diff --git a/harper-core/src/linting/phrase_set_corrections/tests.rs b/harper-core/src/linting/phrase_set_corrections/tests.rs
index 936cb8f82..b9da99b08 100644
--- a/harper-core/src/linting/phrase_set_corrections/tests.rs
+++ b/harper-core/src/linting/phrase_set_corrections/tests.rs
@@ -734,6 +734,53 @@ fn correct_how_it_looks_like_with_apostrophe() {
);
}
+// MakeItSeem
+
+#[test]
+fn corrects_make_it_seems() {
+ assert_suggestion_result(
+ "but put it into unlisted list may make it seems like listed for GitHub",
+ lint_group(),
+ "but put it into unlisted list may make it seem like listed for GitHub",
+ );
+}
+
+#[test]
+fn corrects_made_it_seems() {
+ assert_suggestion_result(
+ "previous explanations made it seems like it would be n",
+ lint_group(),
+ "previous explanations made it seem like it would be n",
+ );
+}
+
+#[test]
+fn corrects_makes_it_seems() {
+ assert_suggestion_result(
+ "bundle gives an error that makes it seems like esbuild is trying to use lib/index.js from main",
+ lint_group(),
+ "bundle gives an error that makes it seem like esbuild is trying to use lib/index.js from main",
+ );
+}
+
+#[test]
+fn corrects_making_it_seems() {
+ assert_suggestion_result(
+ "Is it possible to teach the concept of assignment/reassignment at the very beginner stage instead of making it seems like constants?",
+ lint_group(),
+ "Is it possible to teach the concept of assignment/reassignment at the very beginner stage instead of making it seem like constants?",
+ );
+}
+
+#[test]
+fn corrects_made_it_seemed() {
+ assert_suggestion_result(
+ "The path made it seemed a bit \"internal\".",
+ lint_group(),
+ "The path made it seem a bit \"internal\".",
+ );
+}
+
// RaiseTheQuestion
// -raise the question-