Offline, privacy-first grammar checker. Fast, open-source, Rust-powered
feat: in depth→in-depth (#3684)
Andrew Dunbar369a619c7736
diff --git a/harper-core/default_config.json b/harper-core/default_config.jsonindex 10ff88039..bf27cf88e 100644--- a/harper-core/default_config.json+++ b/harper-core/default_config.json@@ -1728,6 +1728,13 @@"state": true,"label": "Worst Case Scenario"}+ },+ {+ "Bool": {+ "name": "InDemandInDepth",+ "state": true,+ "label": "In Demand / In Depth"+ }}]}diff --git a/harper-core/src/linting/in_demand_in_depth.rs b/harper-core/src/linting/in_demand_in_depth.rsnew file mode 100644index 000000000..b8fdb7ef2--- /dev/null+++ b/harper-core/src/linting/in_demand_in_depth.rs@@ -0,0 +1,131 @@+use crate::{+ Lint, Token, TokenKind,+ expr::{Expr, SequenceExpr},+ linting::{ExprLinter, LintKind, Suggestion, expr_linter::Chunk},+};++pub struct InDemandInDepth {+ expr: SequenceExpr,+}++impl Default for InDemandInDepth {+ fn default() -> Self {+ Self {+ expr: SequenceExpr::default()+ .then_kind_any_but_not(+ // To flag:+ // ✔ [Get] in depth answers - verb lemma+ // ✔ consisting [of] in depth technical discussion - preposition+ // ✔ [more]/[most] - determiner/quantifier? adverb?+ // Not to flag:+ // ✘ explore these [concepts] in depth - plural noun+ // ✘ [Defense] in Depth - abstract/mass noun+ // ✘ and [MCP] in depth - mass noun+ &[+ TokenKind::is_verb_lemma,+ TokenKind::is_preposition,+ TokenKind::is_quantifier,+ TokenKind::is_degree_adverb,+ ],+ TokenKind::is_mass_noun,+ )+ .t_ws()+ .t_aco("in")+ .t_ws()+ .t_set(&["demand", "depth"]),+ }+ }+}++impl ExprLinter for InDemandInDepth {+ type Unit = Chunk;++ fn match_to_lint(&self, toks: &[Token], _src: &[char]) -> Option<Lint> {+ Some(Lint {+ span: toks.get(3)?.span,+ lint_kind: LintKind::Punctuation,+ suggestions: vec![Suggestion::ReplaceWith(vec!['-'])],+ message: "When used as adjectives, `in-demand` and `in-depth` should be hyphenated."+ .to_owned(),+ ..Default::default()+ })+ }++ fn expr(&self) -> &dyn Expr {+ &self.expr+ }++ fn description(&self) -> &str {+ "Checks for `in-demand` and `in-depth` used as adjectives but not hyphenated."+ }+}++#[cfg(test)]+mod tests {+ use crate::linting::tests::assert_suggestion_result;++ use super::InDemandInDepth;++ #[test]+ fn of_in_depth_technical_discussion() {+ assert_suggestion_result(+ "One hour video call consisting of in depth technical discussion with lead developers",+ InDemandInDepth::default(),+ "One hour video call consisting of in-depth technical discussion with lead developers",+ );+ }++ #[test]+ fn a_more_in_depth_documentation() {+ assert_suggestion_result(+ "I have added a more in depth documentation for each concept",+ InDemandInDepth::default(),+ "I have added a more in-depth documentation for each concept",+ );+ }++ #[test]+ fn most_in_demand_job_technologies() {+ assert_suggestion_result(+ "Jupyter notebook for scraping and analysis of most in demand job technologies skills for data scientists",+ InDemandInDepth::default(),+ "Jupyter notebook for scraping and analysis of most in-demand job technologies skills for data scientists",+ );+ }++ #[test]+ fn invited_engineer_to_explain_more_in_depth() {+ assert_suggestion_result(+ "invited one of their engineers to the next meeting to explain this more in depth",+ InDemandInDepth::default(),+ "invited one of their engineers to the next meeting to explain this more in-depth",+ );+ }++ #[test]+ fn very_in_depth_explination() {+ assert_suggestion_result(+ "This is a very in depth explination of naive bayes w.r.t implementation in python",+ InDemandInDepth::default(),+ "This is a very in-depth explination of naive bayes w.r.t implementation in python",+ );+ }++ #[test]+ fn pretty_in_depth_comparison() {+ assert_suggestion_result(+ "there should be a pretty in depth comparison of all of the options in the wiki",+ InDemandInDepth::default(),+ "there should be a pretty in-depth comparison of all of the options in the wiki",+ );+ }++ #[test]+ fn quite_in_depth_analysis() {+ assert_suggestion_result(+ "There was already a quite in depth analysis for Tasmota here",+ InDemandInDepth::default(),+ "There was already a quite in-depth analysis for Tasmota here",+ );+ }+}diff --git a/harper-core/src/linting/lint_group/mod.rs b/harper-core/src/linting/lint_group/mod.rsindex fcaeff999..262cf8037 100644--- a/harper-core/src/linting/lint_group/mod.rs+++ b/harper-core/src/linting/lint_group/mod.rs@@ -114,6 +114,7 @@ use super::how_to::HowTo;use super::hyphenate_number_day::HyphenateNumberDay;use super::i_am_agreement::IAmAgreement;use super::if_wouldve::IfWouldve;+use super::in_demand_in_depth::InDemandInDepth;use super::in_favour_of_doing::InFavourOfDoing;use super::in_on_the_cards::InOnTheCards;use super::in_time_from_now::InTimeFromNow;@@ -682,6 +683,7 @@ impl LintGroup {insert_expr_rule!(HyphenateNumberDay, true);insert_expr_rule!(IAmAgreement, true);insert_expr_rule!(IfWouldve, true);+ insert_expr_rule!(InDemandInDepth, true);insert_expr_rule!(InFavourOfDoing, true);insert_struct_rule_with_dialect!(InOnTheCards, true);insert_expr_rule!(InTimeFromNow, true);diff --git a/harper-core/src/linting/mod.rs b/harper-core/src/linting/mod.rsindex 996fd2f5c..83fb4e31f 100644--- a/harper-core/src/linting/mod.rs+++ b/harper-core/src/linting/mod.rs@@ -111,6 +111,7 @@ mod how_to;mod hyphenate_number_day;mod i_am_agreement;mod if_wouldve;+mod in_demand_in_depth;mod in_favour_of_doing;mod in_on_the_cards;mod in_time_from_now;