Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix: "popup window" false positive (#2218)

Andrew Dunbar36df3b950593
diff --git a/harper-core/src/linting/phrasal_verb_as_compound_noun.rs b/harper-core/src/linting/phrasal_verb_as_compound_noun.rs
index 0a8e84f7e..f93bb68c4 100644
--- a/harper-core/src/linting/phrasal_verb_as_compound_noun.rs
+++ b/harper-core/src/linting/phrasal_verb_as_compound_noun.rs
@@ -221,6 +221,7 @@ impl Linter for PhrasalVerbAsCompoundNoun {
"suite",
"support",
][..],
+ ['p', 'o', 'p', 'u', 'p'] => &["window"][..],
['r', 'o', 'l', 'l', 'o', 'u', 't'] => &["logic", "status"][..],
['s', 't', 'a', 'r', 't', 'u', 'p'] => &["environments"][..],
['t', 'h', 'r', 'o', 'w', 'b', 'a', 'c', 'k'] => &["machine"][..],
@@ -740,4 +741,12 @@ mod tests {
PhrasalVerbAsCompoundNoun::default(),
);
}
+
+ #[test]
+ fn dont_flag_pop_up_2217() {
+ assert_no_lints(
+ "Popup window instead of command line.",
+ PhrasalVerbAsCompoundNoun::default(),
+ );
+ }
}