Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

feat(vscode-plugin): add tests for Dart and PHP

Matthew Espino3a96d8a81ba9
diff --git a/packages/vscode-plugin/package.json b/packages/vscode-plugin/package.json
index eb52c58aa..019d910d7 100644
--- a/packages/vscode-plugin/package.json
+++ b/packages/vscode-plugin/package.json
@@ -35,6 +35,7 @@
"onLanguage:cmake",
"onLanguage:cpp",
"onLanguage:csharp",
+ "onLanguage:dart",
"onLanguage:git-commit",
"onLanguage:go",
"onLanguage:haskell",
@@ -46,6 +47,7 @@
"onLanguage:lua",
"onLanguage:markdown",
"onLanguage:nix",
+ "onLanguage:php",
"onLanguage:plaintext",
"onLanguage:python",
"onLanguage:ruby",
@@ -55,9 +57,7 @@
"onLanguage:toml",
"onLanguage:typescript",
"onLanguage:typescriptreact",
- "onLanguage:typst",
- "onLanguage:php",
- "onLanguage:dart"
+ "onLanguage:typst"
],
"main": "./build/extension.js",
"contributes": {
diff --git a/packages/vscode-plugin/src/tests/fixtures/languages/dart.dart b/packages/vscode-plugin/src/tests/fixtures/languages/dart.dart
new file mode 100644
index 000000000..2fbc4c8a2
--- /dev/null
+++ b/packages/vscode-plugin/src/tests/fixtures/languages/dart.dart
@@ -0,0 +1,5 @@
+void main() { /*
+ Errorz
+ */
+ print("Hello, World!");
+}
diff --git a/packages/vscode-plugin/src/tests/fixtures/languages/php.php b/packages/vscode-plugin/src/tests/fixtures/languages/php.php
new file mode 100644
index 000000000..d26852868
--- /dev/null
+++ b/packages/vscode-plugin/src/tests/fixtures/languages/php.php
@@ -0,0 +1,3 @@
+<?php
+
+echo "Hello World!"; // Errorz
\ No newline at end of file
diff --git a/packages/vscode-plugin/src/tests/suite/languages.test.ts b/packages/vscode-plugin/src/tests/suite/languages.test.ts
index 7556d5dff..87f780e88 100644
--- a/packages/vscode-plugin/src/tests/suite/languages.test.ts
+++ b/packages/vscode-plugin/src/tests/suite/languages.test.ts
@@ -34,12 +34,14 @@ describe('Languages >', () => {
{ type: 'C++', file: 'cpp.cpp', row: 3, column: 5 },
{ type: 'H', file: 'cpp.h', row: 0, column: 3 },
{ type: 'C#', file: 'csharp.cs', row: 2, column: 2 },
+ { type: 'Dart', file: 'dart.dart', row: 1, column: 29 },
{ type: 'Git Commit', file: 'git-commit', row: 0, column: 0 },
{ type: 'Go', file: 'go.go', row: 4, column: 4 },
{ type: 'HTML', file: 'html.html', row: 8, column: 6 },
{ type: 'Java', file: 'java.java', row: 2, column: 17 },
{ type: 'JavaScript', file: 'javascript.js', row: 1, column: 3 },
{ type: 'Lua', file: 'lua.lua', row: 0, column: 24 },
+ { type: 'PHP', file: 'php.php', row: 2, column: 31 },
{ type: 'Plaintext without extension', file: 'plaintext', row: 0, column: 0 },
{ type: 'Plaintext with extension', file: 'plaintext.txt', row: 4, column: 0 },
{ type: 'Python', file: 'python.py', row: 1, column: 2 },
diff --git a/packages/web/src/routes/docs/integrations/language-server/+page.md b/packages/web/src/routes/docs/integrations/language-server/+page.md
index db8acb7b8..c57a65e78 100644
--- a/packages/web/src/routes/docs/integrations/language-server/+page.md
+++ b/packages/web/src/routes/docs/integrations/language-server/+page.md
@@ -91,6 +91,7 @@ If you use Neovim, [read this documentation](./neovim#Configuration).
| CMake | `cmake` | ✅ |
| C++ | `cpp` | ✅ |
| C# | `csharp` | ✅ |
+| Dart | `dart` | ✅ |
| Email | `mail` | |
| Git Commit | `git-commit`/`gitcommit` | |
| Go | `go` | ✅ |
@@ -103,6 +104,7 @@ If you use Neovim, [read this documentation](./neovim#Configuration).
| Lua | `lua` | ✅ |
| Markdown | `markdown` | |
| Nix | `nix` | ✅ |
+| PHP | `php` | ✅ |
| Plain Text | `plaintext` | |
| Python | `python` | ✅ |
| Ruby | `ruby` | ✅ |
@@ -113,8 +115,6 @@ If you use Neovim, [read this documentation](./neovim#Configuration).
| TypeScript | `typescript` | ✅ |
| TypeScript React | `typescriptreact` | ✅ |
| Typst | `typst` | |
-| PHP | `php` | ✅ |
-| Dart | `dart` | ✅ |
Want your language added?
Let us know by [commenting on this issue](https://github.com/Automattic/harper/issues/79).