Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix(core): remove cause of #581

Elijah Potter4e95bc6317ec
diff --git a/harper-core/src/linting/lint_group.rs b/harper-core/src/linting/lint_group.rs
index 053dbecc9..5ae73d9de 100644
--- a/harper-core/src/linting/lint_group.rs
+++ b/harper-core/src/linting/lint_group.rs
@@ -17,7 +17,7 @@ use super::merge_words::MergeWords;
use super::multiple_sequential_pronouns::MultipleSequentialPronouns;
use super::number_suffix_capitalization::NumberSuffixCapitalization;
use super::phrase_corrections::{
- Decision, HumanLife, NeedHelp, NoLonger, OfCourse, ThatChallenged, TurnItOff,
+ HumanLife, NeedHelp, NoLonger, OfCourse, ThatChallenged, TurnItOff,
};
use super::plural_conjugate::PluralConjugate;
use super::pronoun_contraction::PronounContraction;
@@ -198,7 +198,6 @@ create_lint_group_config!(
SomewhatSomething => true,
LetsConfusion => true,
DespiteOf => true,
- Decision => true,
HumanLife => true,
NeedHelp => true,
NoLonger => true,
diff --git a/harper-core/src/linting/mod.rs b/harper-core/src/linting/mod.rs
index 369f28ec7..90e56c6db 100644
--- a/harper-core/src/linting/mod.rs
+++ b/harper-core/src/linting/mod.rs
@@ -63,9 +63,7 @@ pub use multiple_sequential_pronouns::MultipleSequentialPronouns;
pub use number_suffix_capitalization::NumberSuffixCapitalization;
pub use oxford_comma::OxfordComma;
pub use pattern_linter::PatternLinter;
-pub use phrase_corrections::{
- Decision, HumanLife, NeedHelp, NoLonger, OfCourse, ThatChallenged, TurnItOff,
-};
+pub use phrase_corrections::{HumanLife, NeedHelp, NoLonger, OfCourse, ThatChallenged, TurnItOff};
pub use plural_conjugate::PluralConjugate;
pub use pronoun_contraction::PronounContraction;
pub use proper_noun_capitalization_linters::{
diff --git a/harper-core/src/linting/phrase_corrections.rs b/harper-core/src/linting/phrase_corrections.rs
index 384eaded0..0ac7bbcf9 100644
--- a/harper-core/src/linting/phrase_corrections.rs
+++ b/harper-core/src/linting/phrase_corrections.rs
@@ -72,9 +72,7 @@ create_linter_for_phrase!(HumanLife, "human life", 1);
create_linter_for_phrase!(ThatChallenged, "that challenged", 2);
create_linter_for_phrase!(NoLonger, "no longer", 1);
create_linter_for_phrase!(NeedHelp, "need help", 1);
-create_linter_for_phrase!(Decision, "make a decision", 1);
create_linter_for_phrase!(OfCourse, "of course", 1);
-
create_linter_for_phrase!(AndAlike, "and alike", 1);
create_linter_for_phrase!(BadRap, "bad rap", 1);
create_linter_for_phrase!(BatedBreath, "bated breath", 1);
@@ -93,8 +91,8 @@ mod tests {
use crate::linting::tests::{assert_lint_count, assert_suggestion_result};
use super::{
- BadRap, BatedBreath, ChangeTack, Decision, EnMasse, HungerPang, LetAlone, LoAndBehold,
- MootPoint, OfCourse, SneakingSuspicion, SupposeTo, TurnItOff,
+ BadRap, BatedBreath, ChangeTack, EnMasse, HungerPang, LetAlone, LoAndBehold, MootPoint,
+ OfCourse, SneakingSuspicion, SupposeTo, TurnItOff,
};
#[test]
@@ -122,15 +120,6 @@ mod tests {
assert_suggestion_result("Turn i of", TurnItOff::default(), "Turn it off");
}
- #[test]
- fn take_a_decision() {
- assert_suggestion_result(
- "we should take a decision on this",
- Decision::default(),
- "we should make a decision on this",
- );
- }
-
#[test]
fn off_course() {
assert_suggestion_result(