Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

chore: add "something of a" false positive

hippietrail573bfc66a404
diff --git a/harper-core/src/linting/adjective_of_a.rs b/harper-core/src/linting/adjective_of_a.rs
index d7007ba42..037be5885 100644
--- a/harper-core/src/linting/adjective_of_a.rs
+++ b/harper-core/src/linting/adjective_of_a.rs
@@ -31,7 +31,9 @@ impl Linter for AdjectiveOfA {
['k', 'i', 'n', 'd'] | ['K', 'i', 'n', 'd'] => true,
['m', 'e', 'a', 'n', 'i', 'n', 'g'] | ['M', 'e', 'a', 'n', 'i', 'n', 'g'] => true,
['p', 'a', 'r', 't'] | ['P', 'a', 'r', 't'] => true,
- // TODO: consider "more of a" and "less of a"
+ ['s', 'o', 'm', 'e', 't', 'h', 'i', 'n', 'g']
+ | ['S', 'o', 'm', 'e', 't', 'h', 'i', 'n', 'g'] => true,
+ // TODO: consider "more of a" and "less of a" but they may have too many true positives
_ => false,
} {
continue;
@@ -218,4 +220,13 @@ mod tests {
0,
);
}
+
+ #[test]
+ fn dont_flag_something() {
+ assert_lint_count(
+ "Well its popularity seems to be taking something of a dip right now.",
+ AdjectiveOfA,
+ 0,
+ );
+ }
}