Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix(core): pronouns weren't the problem, it was the dictionary

Elijah Potter5b1a9068cfc6
diff --git a/harper-core/dictionary.dict b/harper-core/dictionary.dict
index aa29a4e70..e190eb209 100644
--- a/harper-core/dictionary.dict
+++ b/harper-core/dictionary.dict
@@ -49457,7 +49457,7 @@ you'd/
you'll/
you're/
you've/
-you/841SMH~
+you/84SMH~
young/514TMR
youngish/5
youngster/1MS
diff --git a/harper-core/src/linting/plural_conjugate.rs b/harper-core/src/linting/plural_conjugate.rs
index 5071e543e..8c6e98969 100644
--- a/harper-core/src/linting/plural_conjugate.rs
+++ b/harper-core/src/linting/plural_conjugate.rs
@@ -18,7 +18,7 @@ impl Default for PluralConjugate {
let non_plural_case = SequencePattern::default()
.then(Box::new(|tok: &Token, _source: &[char]| {
- tok.kind.is_not_plural_noun() && tok.kind.is_noun() && !tok.kind.is_pronoun()
+ tok.kind.is_not_plural_noun() && tok.kind.is_noun()
}))
.then_whitespace()
.then_exact_word("are");
@@ -100,4 +100,13 @@ mod tests {
0,
);
}
+
+ #[test]
+ fn pronoun_singular() {
+ assert_suggestion_result(
+ "If he are testing it.",
+ PluralConjugate::default(),
+ "If he is testing it.",
+ );
+ }
}