Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

Merge branch 'master' into in-and-of-itself

Elijah Potter6f3a369ba87d
diff --cc harper-core/src/linting/phrase_corrections.rs
index 6192ca0bd,4e4b30a47..9a64efb34
--- a/harper-core/src/linting/phrase_corrections.rs
+++ b/harper-core/src/linting/phrase_corrections.rs
@@@ -615,12 -615,12 +615,18 @@@ pub fn lint_group() -> LintGroup
"Use `nerve-racking` for something that causes anxiety or tension.",
"Corrects common misspellings and missing hyphen in `nerve-racking`."
),
+ "InAndOfItself" => (
+ ["in of itself"],
+ ["in and of itself"],
+ "Use `in and of itself` for referring to something's inherent or intrinsic quality.",
+ "Corrects nonstandard `in of itself` to standard `in and of itself`."
- )
++ ),
+ "Monumentous" => (
+ ["monumentous"],
+ ["momentous", "monumental"],
+ "Retain `monumentous` for jocular effect. Otherwise `momentous` indicates great signifcance while `monumental` indicates imposing size.",
+ "Advises using `momentous` or `monumental` instead of `monumentous` for serious usage."
+ ),
});
group.set_all_rules_to(Some(true));
@@@ -858,17 -858,17 +864,31 @@@ mod tests
);
}
+ #[test]
+ fn detect_atomic_in_of_itself() {
+ assert_suggestion_result("in of itself", lint_group(), "in and of itself");
+ }
+
+ #[test]
+ fn correct_real_world_in_of_itself() {
+ assert_suggestion_result(
+ "This is not entirely unexpected in of itself, as Git and GitHub Desktop both generally prove fairly bad at delineating context intelligently...",
+ lint_group(),
+ "This is not entirely unexpected in and of itself, as Git and GitHub Desktop both generally prove fairly bad at delineating context intelligently...",
+ );
+ }
++
+ #[test]
+ fn detect_monumentous_atomic() {
+ assert_suggestion_result("monumentous", lint_group(), "momentous");
+ }
+
+ #[test]
+ fn detect_monumentous_real_world() {
+ assert_suggestion_result(
+ "I think that would be a monumentous step in the right direction, and would DEFINATLY turn heads in not just the music industry, but every ...",
+ lint_group(),
+ "I think that would be a momentous step in the right direction, and would DEFINATLY turn heads in not just the music industry, but every ...",
+ );
+ }
}