Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix: not editing list block items

Elijah Potter73169cd702a3
diff --git a/src/harper/DataBlock.ts b/src/harper/DataBlock.ts
index a0ab77808..909a5c7fe 100644
--- a/src/harper/DataBlock.ts
+++ b/src/harper/DataBlock.ts
@@ -1,12 +1,5 @@
-import { Lint, LocalLinter, Suggestion } from 'harper.js';
-import {
- getNodesFromQuerySelector,
- getRangeForTextSpan,
- getRichTextContainers,
-} from './domUtils';
+import { getNodesFromQuerySelector, getRichTextContainers } from './domUtils';
import RichText from './RichText';
-import { LintBox } from './Box';
-import { setBlockContent } from './gutenbergUtils';
import { dispatch } from '@wordpress/data';
/** Represents a Gutenberg block on-screen.
@@ -26,18 +19,14 @@ export default class DataBlock {
let cont = getRichTextContainers( this.targetElement );
return cont.map(
- ( cont, index ) =>
+ ( cont ) =>
new RichText( cont, this, async ( newContent: string ) => {
const { updateBlockAttributes } =
dispatch( 'core/block-editor' );
- if ( cont == this.targetElement ) {
- await updateBlockAttributes( this.getClientId(), {
- content: newContent,
- } );
- } else {
- console.log( 'UNIMPLEMENTED' );
- }
+ await updateBlockAttributes( this.getClientId(), {
+ content: newContent,
+ } );
} )
);
}
@@ -46,11 +35,7 @@ export default class DataBlock {
let container = this.getContainer();
let targetNodes = [
- ...getNodesFromQuerySelector( container, '[data-block].rich-text' ),
- ...getNodesFromQuerySelector(
- container,
- '[data-block].wp-block-list'
- ),
+ ...getNodesFromQuerySelector( container, '[data-block]' ),
];
return targetNodes.map( ( node ) => new DataBlock( node ) );
diff --git a/src/harper/RichText.ts b/src/harper/RichText.ts
index 7f8cc9e37..7c4f21c9f 100644
--- a/src/harper/RichText.ts
+++ b/src/harper/RichText.ts
@@ -6,7 +6,8 @@ import { setBlockContent } from './gutenbergUtils';
export type EditContentCallback = ( newContent: string ) => void;
-/** Represents a rich text element on-screen. */
+/** Represents a rich text element on-screen.
+ * It can either be a child element of a `DataBlock` or be the `DataBlock` itself. */
export default class RichText {
private targetElement: Element;
private parent: DataBlock;