Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

Fix false positive in let/lets→let's (#1158)

Andrew Dunbar7ce6acda4965
diff --git a/harper-core/src/linting/lets_confusion/no_contraction_with_verb.rs b/harper-core/src/linting/lets_confusion/no_contraction_with_verb.rs
index 276faa6bd..752d894df 100644
--- a/harper-core/src/linting/lets_confusion/no_contraction_with_verb.rs
+++ b/harper-core/src/linting/lets_confusion/no_contraction_with_verb.rs
@@ -17,11 +17,13 @@ pub struct NoContractionWithVerb {
impl Default for NoContractionWithVerb {
fn default() -> Self {
+ // Only tests "let".
let let_ws = SequencePattern::default()
.then(WordSet::new(&["lets", "let"]))
.then_whitespace();
// Word is only a verb, and not the gerund/present participle form.
+ // Only tests the next word after "let".
let non_ing_verb = SequencePattern::default().then(|tok: &Token, source: &[char]| {
let Some(Some(meta)) = tok.kind.as_word() else {
return false;
@@ -50,8 +52,13 @@ impl Default for NoContractionWithVerb {
});
// Ambiguous word is a verb determined by heuristic of following word's part of speech
+ // Tests the next two words after "let".
let verb_due_to_following_pos = SequencePattern::default()
- .then(|tok: &Token, _source: &[char]| tok.kind.is_verb() || tok.kind.is_noun())
+ .then(|tok: &Token, source: &[char]| {
+ tok.kind.is_verb()
+ // TODO: because 'US' is a noun, 'us' also gets marked as a noun
+ || (tok.kind.is_noun() && tok.span.get_content(source) != ['u', 's'])
+ })
.then_whitespace()
.then(|tok: &Token, _source: &[char]| {
tok.kind.is_determiner() || tok.kind.is_pronoun() || tok.kind.is_conjunction()
@@ -196,4 +203,11 @@ mod tests {
"Then let's mock them using Module._load based mocker.",
);
}
+
+ // False positives / edge cases files on GitHub
+
+ #[test]
+ fn dont_flag_let_us() {
+ assert_lint_count("Let us do this.", NoContractionWithVerb::default(), 0);
+ }
}