Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix(core): add "understand" to the irregular verb list (#4036)

Mauro Pereira7d1dae577afd
diff --git a/harper-core/irregular_verbs.json b/harper-core/irregular_verbs.json
index e3b020dcf..5bc13ff52 100644
--- a/harper-core/irregular_verbs.json
+++ b/harper-core/irregular_verbs.json
@@ -134,6 +134,7 @@
["think", "thought", "thought"],
["throw", "threw", "thrown"],
["tread", "trod", "trodden"],
+ ["understand", "understood", "understood"],
["undo", "undid", "undone"],
["wake", "woke", "woken"],
["wear", "wore", "worn"],
diff --git a/harper-core/src/linting/did_past.rs b/harper-core/src/linting/did_past.rs
index 314e504cb..848c04ec8 100644
--- a/harper-core/src/linting/did_past.rs
+++ b/harper-core/src/linting/did_past.rs
@@ -303,4 +303,30 @@ mod tests {
DidPast::new(FstDictionary::curated()),
);
}
+
+ #[test]
+ fn issue_3916_didnt_understood() {
+ assert_suggestion_result(
+ "I didn't understood the problem.",
+ DidPast::new(FstDictionary::curated()),
+ "I didn't understand the problem.",
+ );
+ }
+
+ #[test]
+ fn issue_3916_did_understood() {
+ assert_suggestion_result(
+ "I did understood the problem.",
+ DidPast::new(FstDictionary::curated()),
+ "I did understand the problem.",
+ );
+ }
+
+ #[test]
+ fn issue_3916_correct_usage() {
+ assert_no_lints(
+ "I didn't understand the problem.",
+ DidPast::new(FstDictionary::curated()),
+ );
+ }
}