Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix(vscode-plugin): only package extension in workflow

Matthew Espino7d21e8ba2912
diff --git a/.github/workflows/publish_vscode_plugin.yml b/.github/workflows/package_vscode_plugin.yml
similarity index 79%
rename from .github/workflows/publish_vscode_plugin.yml
rename to .github/workflows/package_vscode_plugin.yml
index f1b51d2b7..bea3ef554 100644
--- a/.github/workflows/publish_vscode_plugin.yml
+++ b/.github/workflows/package_vscode_plugin.yml
@@ -1,9 +1,8 @@
-name: Publish VS Code Plugin
+name: Package VS Code Plugin
on:
push:
- tags: ["harper-vscode*"]
- workflow_dispatch:
+ branches: ["master"]
jobs:
package:
@@ -59,17 +58,3 @@ jobs:
with:
name: ${{ matrix.platform.code_target }}
path: "packages/vscode-plugin/*.vsix"
-
- publish:
- name: Publish
- needs: package
- runs-on: ubuntu-latest
- steps:
- - uses: actions/download-artifact@v4
- - uses: actions/setup-node@v4
- with:
- node-version: 20
- - name: Publish extension
- run: npx @vscode/vsce publish --packagePath $(find . -iname *.vsix)
- env:
- VSCE_PAT: ${{ secrets.VSCE_PAT }}
diff --git a/justfile b/justfile
index c03e8a9d0..2bb499200 100644
--- a/justfile
+++ b/justfile
@@ -66,7 +66,7 @@ test-vscode:
fi
# Build and package the Visual Studio Code extension.
-# If `target` is passed, it is assumed that `harper-ls` has been compiled beforehand and is in `packages/vscode-plugin/bin`. This is used in CI when publishing the extension.
+# If `target` is passed, it is assumed that `harper-ls` has been compiled beforehand and is in `packages/vscode-plugin/bin`. This is used in CI.
package-vscode target="":
#! /bin/bash
set -eo pipefail
diff --git a/packages/vscode-plugin/development-guide.md b/packages/vscode-plugin/development-guide.md
index 3192196d3..6fd16ee06 100644
--- a/packages/vscode-plugin/development-guide.md
+++ b/packages/vscode-plugin/development-guide.md
@@ -1,6 +1,6 @@
# Development Guide
-This document details how to develop the extension locally. If you're interested in how it's published, you can checkout the [Publish VS Code Plugin](/.github/workflows/publish_vscode_plugin.yml) workflow.
+This document details how to develop the extension locally. If you're interested in how it's packaged for distribution, you can checkout the [Package VS Code Plugin](/.github/workflows/package_vscode_plugin.yml) workflow.
## Notes