Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

feat: windscreen vs windshield regionalism (#1888)

Andrew Dunbar80040ee7775a
diff --git a/harper-core/src/linting/regionalisms.rs b/harper-core/src/linting/regionalisms.rs
index 8430f1bf7..7a0e6e22c 100644
--- a/harper-core/src/linting/regionalisms.rs
+++ b/harper-core/src/linting/regionalisms.rs
@@ -56,6 +56,7 @@ enum Concept {
PramStroller,
SpannerWrench,
StationWagonEstate,
+ WindscreenWindshield,
}
use Concept::*;
@@ -449,6 +450,18 @@ const REGIONAL_TERMS: &[Term<'_>] = &[
dialects: &[American],
concept: SpannerWrench,
},
+ Term {
+ term: "windscreen",
+ flag: Flag,
+ dialects: &[British, Australian],
+ concept: WindscreenWindshield,
+ },
+ Term {
+ term: "windshield",
+ flag: Flag,
+ dialects: &[American, Canadian],
+ concept: WindscreenWindshield,
+ },
];
pub struct Regionalisms {
@@ -629,4 +642,13 @@ mod tests {
0,
)
}
+
+ #[test]
+ fn uk_to_us_windscreen() {
+ assert_top3_suggestion_result(
+ "Detect raindrops on vehicle windscreen by combining various region proposal algorithm with Convolutional Neural Network.",
+ Regionalisms::new(Dialect::American),
+ "Detect raindrops on vehicle windshield by combining various region proposal algorithm with Convolutional Neural Network.",
+ )
+ }
}