Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

feat: detect browser dialect (#2485)

Andrew Dunbar935e59a2d669
diff --git a/harper-core/dictionary.dict b/harper-core/dictionary.dict
index 8e9f89114..11fde48b3 100644
--- a/harper-core/dictionary.dict
+++ b/harper-core/dictionary.dict
@@ -16905,10 +16905,10 @@ centavo/NSg
centenarian/NgSJ
centenary/~JNSgV
centennial/~JYNgS
-center/~NgJVdG
-centerboard/NSg
-centerfold/NgS
-centerpiece/~NgS
+center/~NgJVdG<
+centerboard/NSg<
+centerfold/NgS<
+centerpiece/~NgS<
# centi # prefixes that are not also words in their own right don't belong in the dictionary
centigrade/JN
centigram/NSg
@@ -16931,9 +16931,7 @@ centralizer/NgS
centre/NgSVGd!@_₹
centreboard/NSg!@_₹
centrefold/NSg!@_₹
-centreleft/NgS!@_₹
centrepiece/NSg!@_₹
-centreright/NgS!@_₹
centric/~J
centrifugal/~JYN
centrifuge/~NSgVdG
@@ -53616,6 +53614,8 @@ carbon-intensive/J
cash flow/NgS
cash-strapped/J
CD-ROM/NgS
+centre-left/NgS!@_₹
+centre-right/NgS!@_₹
centre-left/J!@_₹
centre-right/J!@_₹
cheat sheet/NgS
diff --git a/harper-core/tests/text/tagged/Computer science.md b/harper-core/tests/text/tagged/Computer science.md
index 26cf253fa..aa5c5293c 100644
--- a/harper-core/tests/text/tagged/Computer science.md
+++ b/harper-core/tests/text/tagged/Computer science.md
@@ -784,8 +784,8 @@
# NSg/VB/J . N🅪Sg+ . NPr/J/R/P NSg/VB+ Nᴹ+ NPr/VXB NSg/VXB VP/J P D N🅪Sg/VB P NPr ?
> Johnson and Frederick P. Brooks Jr . , members of the Machine Organization
# NPr VB/C NPr+ ? NPrPl/V3 NSg/J+ . . NPl/V3 P D+ NSg/VB+ N🅪Sg+
-> department in IBM's main research center in 1959 .
-# NSg+ NPr/J/R/P NPr$ NSg/VB/J+ Nᴹ/VB+ NSg/VB/J+ NPr/J/R/P # .
+> department in IBM's main research center in 1959 .
+# NSg+ NPr/J/R/P NPr$ NSg/VB/J+ Nᴹ/VB+ NSg/VB/J/Am+ NPr/J/R/P # .
>
#
> Concurrent , parallel and distributed computing
diff --git a/packages/chrome-plugin/src/background/detectDialect.ts b/packages/chrome-plugin/src/background/detectDialect.ts
new file mode 100644
index 000000000..c61d629c2
--- /dev/null
+++ b/packages/chrome-plugin/src/background/detectDialect.ts
@@ -0,0 +1,38 @@
+import { Dialect } from 'harper.js';
+
+/** Detect English dialect from browser language settings */
+export function detectBrowserDialect(): Dialect {
+ // Try chrome.i18n API first
+ if (chrome.i18n?.getUILanguage) {
+ const locale = chrome.i18n.getUILanguage();
+ return localeToDialect(locale);
+ }
+
+ // Fallback to navigator.language
+ const lang = navigator.language || navigator.languages?.[0] || 'en-US';
+ return localeToDialect(lang);
+}
+
+/** Map locale string to Dialect */
+function localeToDialect(locale: string): Dialect {
+ const lower = locale.toLowerCase();
+
+ // Explicit matches
+ if (lower.includes('en-gb') || lower.includes('en_gb')) return Dialect.British;
+ if (lower.includes('en-au') || lower.includes('en_au')) return Dialect.Australian;
+ if (lower.includes('en-ca') || lower.includes('en_ca')) return Dialect.Canadian;
+ if (lower.includes('en-in') || lower.includes('en_in')) return Dialect.Indian;
+
+ // Fallback for English variants
+ if (lower.startsWith('en')) {
+ // New Zealand → Australian (closest match)
+ if (lower.includes('en-nz') || lower.includes('en_nz')) return Dialect.Australian;
+ // Other English variants → British as fallback
+ if (lower.match(/^en[-_]/)) return Dialect.British;
+ // Plain 'en' → American (default)
+ return Dialect.American;
+ }
+
+ // Non-English languages → American (fallback)
+ return Dialect.American;
+}
diff --git a/packages/chrome-plugin/src/background/index.ts b/packages/chrome-plugin/src/background/index.ts
index 3f8bebc52..ac071d442 100644
--- a/packages/chrome-plugin/src/background/index.ts
+++ b/packages/chrome-plugin/src/background/index.ts
@@ -1,4 +1,4 @@
-import { BinaryModule, Dialect, type LintConfig, LocalLinter } from 'harper.js';
+import { BinaryModule, type Dialect, type LintConfig, LocalLinter } from 'harper.js';
import { type UnpackedLintGroups, unpackLint } from 'lint-framework';
import type { PopupState } from '../PopupState';
import {
@@ -42,6 +42,7 @@ import {
type SetUserDictionaryRequest,
type UnitResponse,
} from '../protocol';
+import { detectBrowserDialect } from './detectDialect';
console.log('background is running');
@@ -60,7 +61,9 @@ chrome.runtime.onMessage.addListener((request, _sender, sendResponse) => {
let linter: LocalLinter;
-getDialect().then(setDialect);
+getDialect()
+ .then(setDialect)
+ .catch((err) => console.error('Failed to initialize linter:', err));
setInstalledOnIfMissing();
async function enableDefaultDomains() {
@@ -403,7 +406,13 @@ async function getIgnoredLints(): Promise<string> {
}
async function getDialect(): Promise<Dialect> {
- const resp = await chrome.storage.local.get({ dialect: Dialect.American });
+ const resp = await chrome.storage.local.get({ dialect: undefined });
+
+ // If user hasn't set a dialect, try to detect from browser language
+ if (resp.dialect === undefined) {
+ return detectBrowserDialect();
+ }
+
return resp.dialect;
}