Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix: duplicate items in lint sidebar

Elijah Potterad7150b04ff5
diff --git a/src/harper/DataBlock.ts b/src/harper/DataBlock.ts
index a93bafe69..f8efbf0b0 100644
--- a/src/harper/DataBlock.ts
+++ b/src/harper/DataBlock.ts
@@ -30,6 +30,8 @@ export default class DataBlock {
cont.getAttribute('data-wp-block-attribute-key') ??
'content';
+ console.log(this.getClientId());
+
await updateBlockAttributes(this.getClientId(), {
[attributeName]: newContent,
});
@@ -47,6 +49,25 @@ export default class DataBlock {
return targetNodes.map((node) => new DataBlock(node));
}
+ /** Get all DataBlocks in the document, then remove any that have other DataBlocks as children. */
+ public static getTerminalDataBlocks(): DataBlock[] {
+ const blocks = this.getAllDataBlocks();
+
+ return blocks.filter((block) => {
+ for (const otherBlock of blocks) {
+ if (otherBlock === block) {
+ continue;
+ }
+
+ if (block.targetElement.contains(otherBlock.targetElement)) {
+ return false;
+ }
+ }
+
+ return true;
+ });
+ }
+
public static getContainer(): Element {
const iframe = document.querySelector('iframe[name="editor-canvas"]');
const iframeDocument =
diff --git a/src/harper/SidebarControl.tsx b/src/harper/SidebarControl.tsx
index 84610fe03..426474857 100644
--- a/src/harper/SidebarControl.tsx
+++ b/src/harper/SidebarControl.tsx
@@ -1,3 +1,4 @@
+import { uniqBy } from 'lodash-es';
import DataBlock from './DataBlock';
import React, { useCallback, useEffect, useMemo, useState } from 'react';
import { createPortal } from 'react-dom';
@@ -13,7 +14,7 @@ export default function SidebarControl() {
const [blocks, setBlocks] = useState<DataBlock[]>([]);
const updateBlocks = useCallback(
- () => setBlocks(DataBlock.getAllDataBlocks()),
+ () => setBlocks(DataBlock.getTerminalDataBlocks()),
[]
);