Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix: don't flag when contraction comes after a form of be, only before (#3572)

Andrew Dunbarbc7649cd76cd
diff --git a/harper-core/src/linting/single_be.rs b/harper-core/src/linting/single_be.rs
index 21982147b..6b9aefbc7 100644
--- a/harper-core/src/linting/single_be.rs
+++ b/harper-core/src/linting/single_be.rs
@@ -1,9 +1,8 @@
-use crate::dict_word_metadata::VerbFormFlags;
-use crate::linting::expr_linter::Chunk;
use crate::{
Span, Token,
+ dict_word_metadata::VerbFormFlags,
expr::{Expr, SequenceExpr},
- linting::{ExprLinter, Lint, LintKind, Suggestion},
+ linting::{ExprLinter, Lint, LintKind, Suggestion, expr_linter::Chunk},
patterns::{DerivedFrom, InflectionOfBe},
};
@@ -66,11 +65,17 @@ impl Default for SingleBe {
SequenceExpr::any_of(vec![
Box::new(InflectionOfBe::new()),
Box::new(DerivedFrom::new_from_str("be")),
+ ])
+ }
+
+ fn be_like_or_contraction() -> SequenceExpr {
+ SequenceExpr::any_of(vec![
+ Box::new(be_like_expr()),
Box::new(looks_like_be_contraction),
])
}
- let expr = SequenceExpr::with(be_like_expr())
+ let expr = SequenceExpr::with(be_like_or_contraction())
.t_ws()
.then(be_like_expr());
@@ -274,4 +279,12 @@ mod tests {
fn ignores_single_be() {
assert_no_lints("This is ready.", SingleBe::default());
}
+
+ #[test]
+ fn dont_flag_be_noun_apostrophe_s() {
+ assert_no_lints(
+ "Tiram seat believed to be DAP’s offer to Marina",
+ SingleBe::default(),
+ );
+ }
}