Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix: issue #132

Elijah Potterbd21b5353046
diff --git a/harper-comments/src/comment_parsers/unit.rs b/harper-comments/src/comment_parsers/unit.rs
index 2cd505401..f53379f04 100644
--- a/harper-comments/src/comment_parsers/unit.rs
+++ b/harper-comments/src/comment_parsers/unit.rs
@@ -16,8 +16,18 @@ impl Parser for Unit {
let mut tokens = Vec::new();
let mut chars_traversed = 0;
+ let mut in_code_fence = false;
for line in source.split(|c| *c == '\n') {
+ if line_is_code_fence(line) {
+ in_code_fence = !in_code_fence;
+ }
+
+ if in_code_fence {
+ chars_traversed += line.len() + 1;
+ continue;
+ }
+
let mut new_tokens = parse_line(line);
new_tokens.push(Token::new(
@@ -56,3 +66,12 @@ fn parse_line(source: &[char]) -> Vec<Token> {
new_tokens
}
+
+fn line_is_code_fence(source: &[char]) -> bool {
+ let actual = without_initiators(source);
+ let actual_chars = actual.get_content(source);
+
+ dbg!(actual_chars);
+
+ matches!(actual_chars, ['`', '`', '`', ..])
+}
diff --git a/harper-comments/tests/language_support.rs b/harper-comments/tests/language_support.rs
index 2112440e7..4f1d6877b 100644
--- a/harper-comments/tests/language_support.rs
+++ b/harper-comments/tests/language_support.rs
@@ -45,3 +45,4 @@ create_test!(issue_96.lua, 0);
create_test!(merged_lines.ts, 1);
create_test!(javadoc_clean_simple.java, 0);
create_test!(javadoc_complex.java, 4);
+create_test!(issue_132.rs, 1);
diff --git a/harper-comments/tests/language_support_sources/issue_132.rs b/harper-comments/tests/language_support_sources/issue_132.rs
new file mode 100644
index 000000000..44e7eece3
--- /dev/null
+++ b/harper-comments/tests/language_support_sources/issue_132.rs
@@ -0,0 +1,8 @@
+/// ```
+/// println!("Test");
+/// ```
+///
+/// This shoud get checked.
+fn main() {
+ println!("Hello, world!");
+}
diff --git a/harper-core/src/span.rs b/harper-core/src/span.rs
index 4783805c3..023701d84 100644
--- a/harper-core/src/span.rs
+++ b/harper-core/src/span.rs
@@ -44,6 +44,9 @@ impl Span {
/// invalid.
pub fn try_get_content<'a>(&self, source: &'a [char]) -> Option<&'a [char]> {
if (self.start > self.end) || (self.start >= source.len()) || (self.end > source.len()) {
+ if self.is_empty() {
+ return Some(&source[0..0]);
+ }
return None;
}