Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

refactor: don't allocate when linting chunks (#1242)

Michael Schmidtd30d83cba593
diff --git a/harper-core/src/linting/pattern_linter.rs b/harper-core/src/linting/pattern_linter.rs
index eaca06f82..49d7bd895 100644
--- a/harper-core/src/linting/pattern_linter.rs
+++ b/harper-core/src/linting/pattern_linter.rs
@@ -45,13 +45,15 @@ where
}
}
-pub fn run_on_chunk(linter: &impl PatternLinter, chunk: &[Token], source: &[char]) -> Vec<Lint> {
- let mut lints = Vec::new();
-
- for match_span in linter.pattern().iter_matches(chunk, source) {
- let lint = linter.match_to_lint(&chunk[match_span.start..match_span.end], source);
- lints.extend(lint);
- }
-
- lints
+pub fn run_on_chunk(
+ linter: &impl PatternLinter,
+ chunk: &[Token],
+ source: &[char],
+) -> impl Iterator<Item = Lint> {
+ linter
+ .pattern()
+ .iter_matches(chunk, source)
+ .filter_map(|match_span| {
+ linter.match_to_lint(&chunk[match_span.start..match_span.end], source)
+ })
}