Offline, privacy-first grammar checker. Fast, open-source, Rust-powered
feat(web): detect browser when the user submits feedback upon uninstallation (#4746)
Elijah Potterdda8c24b90f6
diff --git a/packages/web/drizzle/0005_old_shiva.sql b/packages/web/drizzle/0005_old_shiva.sqlnew file mode 100644index 000000000..2f97b119e--- /dev/null+++ b/packages/web/drizzle/0005_old_shiva.sql@@ -0,0 +1 @@+ALTER TABLE `uninstall_feedback` ADD `platform` text;\ No newline at end of filediff --git a/packages/web/drizzle/meta/0005_snapshot.json b/packages/web/drizzle/meta/0005_snapshot.jsonnew file mode 100644index 000000000..0c4e5fb60--- /dev/null+++ b/packages/web/drizzle/meta/0005_snapshot.json@@ -0,0 +1,200 @@+{+ "version": "5",+ "dialect": "mysql",+ "id": "643b59a4-a91b-4803-98f7-a0a3dcda8326",+ "prevId": "7dd6b319-eb00-46a8-bf7b-f7569ccf2089",+ "tables": {+ "domain_review": {+ "name": "domain_review",+ "columns": {+ "id": {+ "name": "id",+ "type": "int",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": true+ },+ "works": {+ "name": "works",+ "type": "boolean",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false+ },+ "feedback": {+ "name": "feedback",+ "type": "text",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false+ },+ "domain": {+ "name": "domain",+ "type": "text",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false+ },+ "timestamp": {+ "name": "timestamp",+ "type": "timestamp",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false,+ "default": "(now())"+ }+ },+ "indexes": {},+ "foreignKeys": {},+ "compositePrimaryKeys": {+ "domain_review_id": {+ "name": "domain_review_id",+ "columns": ["id"]+ }+ },+ "uniqueConstraints": {},+ "checkConstraint": {}+ },+ "problematic_lint": {+ "name": "problematic_lint",+ "columns": {+ "id": {+ "name": "id",+ "type": "int",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": true+ },+ "is_false_positive": {+ "name": "is_false_positive",+ "type": "boolean",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false+ },+ "example": {+ "name": "example",+ "type": "text",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false+ },+ "feedback": {+ "name": "feedback",+ "type": "text",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false+ },+ "rule_id": {+ "name": "rule_id",+ "type": "text",+ "primaryKey": false,+ "notNull": false,+ "autoincrement": false+ },+ "timestamp": {+ "name": "timestamp",+ "type": "timestamp",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false,+ "default": "(now())"+ }+ },+ "indexes": {},+ "foreignKeys": {},+ "compositePrimaryKeys": {+ "problematic_lint_id": {+ "name": "problematic_lint_id",+ "columns": ["id"]+ }+ },+ "uniqueConstraints": {},+ "checkConstraint": {}+ },+ "uninstall_feedback": {+ "name": "uninstall_feedback",+ "columns": {+ "id": {+ "name": "id",+ "type": "int",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": true+ },+ "feedback": {+ "name": "feedback",+ "type": "text",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false+ },+ "timestamp": {+ "name": "timestamp",+ "type": "timestamp",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false,+ "default": "(now())"+ },+ "platform": {+ "name": "platform",+ "type": "text",+ "primaryKey": false,+ "notNull": false,+ "autoincrement": false+ }+ },+ "indexes": {},+ "foreignKeys": {},+ "compositePrimaryKeys": {+ "uninstall_feedback_id": {+ "name": "uninstall_feedback_id",+ "columns": ["id"]+ }+ },+ "uniqueConstraints": {},+ "checkConstraint": {}+ },+ "update_check_counts": {+ "name": "update_check_counts",+ "columns": {+ "date": {+ "name": "date",+ "type": "date",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false+ },+ "count": {+ "name": "count",+ "type": "int",+ "primaryKey": false,+ "notNull": true,+ "autoincrement": false+ }+ },+ "indexes": {},+ "foreignKeys": {},+ "compositePrimaryKeys": {+ "update_check_counts_date": {+ "name": "update_check_counts_date",+ "columns": ["date"]+ }+ },+ "uniqueConstraints": {},+ "checkConstraint": {}+ }+ },+ "views": {},+ "_meta": {+ "schemas": {},+ "tables": {},+ "columns": {}+ },+ "internal": {+ "tables": {},+ "indexes": {}+ }+}diff --git a/packages/web/drizzle/meta/_journal.json b/packages/web/drizzle/meta/_journal.jsonindex 99cbd7808..b12f2a197 100644--- a/packages/web/drizzle/meta/_journal.json+++ b/packages/web/drizzle/meta/_journal.json@@ -36,6 +36,13 @@"when": 1789072725878,"tag": "0004_charming_redwing","breakpoints": true+ },+ {+ "idx": 5,+ "version": "5",+ "when": 1793285585090,+ "tag": "0005_old_shiva",+ "breakpoints": true}]}diff --git a/packages/web/package.json b/packages/web/package.jsonindex ad69cb309..65e81148d 100644--- a/packages/web/package.json+++ b/packages/web/package.json@@ -38,6 +38,7 @@"brace": "^0.11.1","chart.js": "^4.4.8","components": "workspace:*",+ "detect-browser": "^5.3.0","drizzle-orm": "^0.44.6","drizzle-zod": "^0.8.3","harper-editor": "workspace:*",diff --git a/packages/web/src/lib/db/schema.ts b/packages/web/src/lib/db/schema.tsindex 56cd8c02a..3d7b1ea40 100644--- a/packages/web/src/lib/db/schema.ts+++ b/packages/web/src/lib/db/schema.ts@@ -4,6 +4,7 @@ export const uninstallFeedbackTable = mysqlTable('uninstall_feedback', {id: int().autoincrement().primaryKey(),feedback: text().notNull(),timestamp: timestamp().notNull().defaultNow(),+ platform: text(),});export const problematicLintTable = mysqlTable('problematic_lint', {diff --git a/packages/web/src/lib/getBrowserType.ts b/packages/web/src/lib/getBrowserType.tsnew file mode 100644index 000000000..53eafaa2c--- /dev/null+++ b/packages/web/src/lib/getBrowserType.ts@@ -0,0 +1,21 @@+import { detect } from 'detect-browser';++/** Gets the type of browser the user is using. Defaults to Chrome if undecidable. */+export default function getBrowserType(): 'chrome' | 'firefox' | 'edge' {+ const browser = detect();++ if (browser == null) {+ return 'chrome';+ }++ switch (browser.name) {+ case 'edge':+ case 'chrome':+ case 'firefox':+ return browser.name;+ case 'edge-chromium':+ return 'edge';+ default:+ return 'chrome';+ }+}diff --git a/packages/web/src/routes/api/uninstall-feedback/+server.ts b/packages/web/src/routes/api/uninstall-feedback/+server.tsindex 0d44672b9..b5f6b07cd 100644--- a/packages/web/src/routes/api/uninstall-feedback/+server.ts+++ b/packages/web/src/routes/api/uninstall-feedback/+server.ts@@ -6,6 +6,7 @@ export const POST = async ({ request }: RequestEvent) => {await UninstallFeedback.validateAndCreate({feedback: data.get('feedback'),+ platform: data.get('platform'),});throw redirect(303, '/');};diff --git a/packages/web/src/routes/uninstall-browser-extension/+page.svelte b/packages/web/src/routes/uninstall-browser-extension/+page.svelteindex cd34befd0..6fc8465ee 100644--- a/packages/web/src/routes/uninstall-browser-extension/+page.svelte+++ b/packages/web/src/routes/uninstall-browser-extension/+page.svelte@@ -1,5 +1,7 @@<script lang="ts">-import { Button, Card, Input, Isolate, SendIcon } from 'components';+import { Button, Card, Checkbox, Input, Isolate, SendIcon } from 'components';+import { onMount } from 'svelte';+import getBrowserType from '$lib/getBrowserType';const reasons = {confused: 'I was confused by how it worked',@@ -13,6 +15,11 @@ const reasons = {let selected: string | undefined;let otherText = '';+let platform = '';++onMount(() => {+ platform = getBrowserType();+});/** Replace the Other reason with its trimmed answer when nonempty; keep the reason otherwise. */function handleFormData(e: FormDataEvent) {@@ -76,6 +83,10 @@ function handleFormData(e: FormDataEvent) {{/if}</fieldset>+ <Checkbox name="platform" value={platform} checked>+ Include browser type+ </Checkbox>+<div class="flex flex-col items-stretch gap-3 sm:flex-row sm:flex-wrap sm:items-center sm:justify-between"><Button type="submit" size="lg" disabled={!selected}>Senddiff --git a/pnpm-lock.yaml b/pnpm-lock.yamlindex 3c339af97..8dcc172bf 100644--- a/pnpm-lock.yaml+++ b/pnpm-lock.yaml@@ -80,7 +80,7 @@ importers:version: 5.43.12svelte-check:specifier: ^4.0.0tailwindcss:specifier: ^4.2.2version: 4.2.4@@ -118,7 +118,7 @@ importers:version: link:../lint-frameworklodash-es:specifier: ^4.17.21- version: 4.17.21+ version: 4.18.1lru-cache:specifier: ^11.1.0version: 11.1.0@@ -500,7 +500,7 @@ importers:version: link:../harper.jslodash-es:specifier: ^4.17.21- version: 4.17.21+ version: 4.18.1minimatch:specifier: ^10.0.3version: 10.0.3@@ -608,6 +608,9 @@ importers:components:specifier: workspace:*version: link:../components+ detect-browser:+ specifier: ^5.3.0+ version: 5.3.0drizzle-orm:specifier: ^0.44.6version: 0.44.6(@libsql/[email protected])([email protected])@@ -625,7 +628,7 @@ importers:version: link:../lint-frameworklodash-es:specifier: ^4.17.21- version: 4.17.21+ version: 4.18.1mysql2:specifier: ^3.15.2version: 3.15.2@@ -725,7 +728,7 @@ importers:version: link:../harper.jslodash-es:specifier: ^4.17.21- version: 4.17.21+ version: 4.18.1react:specifier: ^18.0.0version: 18.3.1@@ -7075,6 +7078,9 @@ packages:resolution: {integrity: sha512-2sJGJTaXIIaR1w4iJSNoN0hnMY7Gpc/n8D4qSCJw8QqFWXf7cuAgnEHxBpweaVcPevC2l3KpjYCx3NypQQgaJg==}engines: {node: '>= 0.8', npm: 1.2.8000 || >= 1.4.16}+ resolution: {integrity: sha512-53rsFbGdwMwlF7qvCt0ypLM5V5/Mbl0szB7GPN8y9NCcbknYOeVVXdrXEq+90IwAfrrzt6Hd+u2E2ntakICU8w==}+resolution: {integrity: sha512-DtCOLG98P007x7wiiOmfI0fi3eIKyWiLTGJ2MDnVi/E04lWGbf+JzrRHMm0rgIIZJGtHpKpbVgLWHrv8xXpc3Q==}engines: {node: '>=0.10.0'}@@ -9566,9 +9572,6 @@ packages:resolution: {integrity: sha512-gvVijfZvn7R+2qyPX8mAuKcFGDf6Nc61GdvGafQsHL0sBIxfKzA+usWn4GFC/bk+QdwPUD4kWFJLhElipq+0VA==}engines: {node: ^12.20.0 || ^14.13.1 || >=16.0.0}- resolution: {integrity: sha512-mKnC+QJ9pWVzv+C4/U3rRsHapFfHvQFoFB92e52xeyGMcX6/OlIl78je1u8vePzYZSkkogMPJ2yjxxsb89cxyw==}-resolution: {integrity: sha512-J8xewKD/Gk22OZbhpOVSwcs60zhd95ESDwezOFuA3/099925PdHJ7OFHNTGtajL3AlZkykD32HykiMo+BIBI8A==}@@ -21809,6 +21812,8 @@ snapshots:+ [email protected]: {}+@@ -24807,8 +24812,6 @@ snapshots:dependencies:p-locate: 6.0.0- [email protected]: {}-@@ -26548,7 +26551,7 @@ snapshots:dependencies:eventemitter3: 5.0.1- lodash-es: 4.17.21+ lodash-es: 4.18.1parchment: 3.0.0quill-delta: 5.1.0@@ -27814,18 +27817,6 @@ snapshots:svelte: 5.43.12zimmerframe: 1.1.2- dependencies:- '@jridgewell/trace-mapping': 0.3.25- chokidar: 4.0.3- fdir: 6.4.4([email protected])- picocolors: 1.1.1- sade: 1.8.1- svelte: 5.43.12- typescript: 5.6.3- transitivePeerDependencies:- - picomatch-dependencies:'@jridgewell/trace-mapping': 0.3.25