Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

chore: "off of a" false positive

hippietraile055a9c43332
diff --git a/harper-core/src/linting/adjective_of_a.rs b/harper-core/src/linting/adjective_of_a.rs
index c7200e5d0..73f0eb6d4 100644
--- a/harper-core/src/linting/adjective_of_a.rs
+++ b/harper-core/src/linting/adjective_of_a.rs
@@ -15,6 +15,7 @@ const FALSE_POSITIVES: &[&str] = &[
"inside",
"more",
"much",
+ "off",
"out",
"shy",
"up",
@@ -497,4 +498,15 @@ mod tests {
0,
);
}
+
+ #[test]
+ fn dont_flag_off() {
+ // Can be an adjective in e.g. "The TV is off".
+ // This should be in a different lint that handles based on/off/off of.
+ assert_lint_count(
+ "can't identify a person based off of an IP from 10 years ago",
+ AdjectiveOfA,
+ 0,
+ );
+ }
}