Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

feat: ignore shebang lines

Brett Holmane2c2b4c4b308
diff --git a/harper-comments/src/masker.rs b/harper-comments/src/masker.rs
index 8f51976ce..b6147df87 100644
--- a/harper-comments/src/masker.rs
+++ b/harper-comments/src/masker.rs
@@ -27,6 +27,7 @@ impl CommentMasker {
|| text.contains("cspell: ignore")
|| text.contains("harper:ignore")
|| text.contains("harper: ignore")
+ || text.starts_with("#!")
}),
)
}
diff --git a/harper-comments/tests/language_support.rs b/harper-comments/tests/language_support.rs
index 391d93f6c..1d58160f9 100644
--- a/harper-comments/tests/language_support.rs
+++ b/harper-comments/tests/language_support.rs
@@ -50,6 +50,10 @@ create_test!(javadoc_clean_simple.java, 0);
create_test!(javadoc_complex.java, 5);
create_test!(issue_132.rs, 1);
create_test!(laravel_app.php, 2);
+create_test!(ignore_shebang_1.sh, 0);
+create_test!(ignore_shebang_2.sh, 0);
+create_test!(ignore_shebang_3.sh, 0);
+create_test!(ignore_shebang_4.sh, 1);
// Checks that some comments are masked out
create_test!(ignore_comments.rs, 1);
diff --git a/harper-comments/tests/language_support_sources/ignore_shebang_1.sh b/harper-comments/tests/language_support_sources/ignore_shebang_1.sh
new file mode 100644
index 000000000..c86269942
--- /dev/null
+++ b/harper-comments/tests/language_support_sources/ignore_shebang_1.sh
@@ -0,0 +1,2 @@
+#!/bin/sh
+# This is a test to make sure that we don't lint shebang lines.
diff --git a/harper-comments/tests/language_support_sources/ignore_shebang_2.sh b/harper-comments/tests/language_support_sources/ignore_shebang_2.sh
new file mode 100644
index 000000000..47adc2478
--- /dev/null
+++ b/harper-comments/tests/language_support_sources/ignore_shebang_2.sh
@@ -0,0 +1,2 @@
+#! /usr/bin/env sh
+# This is a test to make sure that we don't lint shebang lines.
diff --git a/harper-comments/tests/language_support_sources/ignore_shebang_3.sh b/harper-comments/tests/language_support_sources/ignore_shebang_3.sh
new file mode 100644
index 000000000..f0268f750
--- /dev/null
+++ b/harper-comments/tests/language_support_sources/ignore_shebang_3.sh
@@ -0,0 +1,2 @@
+#!/usr/bin/python3
+# This is a test to make sure that we don't lint shebang lines.
diff --git a/harper-comments/tests/language_support_sources/ignore_shebang_4.sh b/harper-comments/tests/language_support_sources/ignore_shebang_4.sh
new file mode 100644
index 000000000..4234cd1a9
--- /dev/null
+++ b/harper-comments/tests/language_support_sources/ignore_shebang_4.sh
@@ -0,0 +1,2 @@
+#/bin/sh
+# This is a test to make sure that we don't ignore invalid shebang lines.