Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix(core): tag fought and wrought as past forms (#3930)

Nathane915595de268
diff --git a/harper-core/dictionary.dict b/harper-core/dictionary.dict
index 8faae1d82..6fceec4ba 100644
--- a/harper-core/dictionary.dict
+++ b/harper-core/dictionary.dict
@@ -25869,7 +25869,7 @@ fossilise/VGdS!_₹
fossilization/Ng
fossilize/VGdS
foster/~JNSVGd
-fought/~V
+fought/~VtT
foul/~JY^>pVdGSNg
foulard/Ng
foulmouthed/J
@@ -53560,7 +53560,7 @@ wrongheadedness/Ng
wrongness/Ng
wrote/~Vtr
wroth/J
-wrought/~JV
+wrought/~JVtT
wrung/V
wry/~JYVN
wryer/Jc
diff --git a/harper-core/src/linting/pronoun_verb_agreement.rs b/harper-core/src/linting/pronoun_verb_agreement.rs
index e2d9ec873..b6c6931d2 100644
--- a/harper-core/src/linting/pronoun_verb_agreement.rs
+++ b/harper-core/src/linting/pronoun_verb_agreement.rs
@@ -290,6 +290,14 @@ mod lints {
assert_no_lints("He likes this place. I sit under the AC.", test_linter());
}
+ #[test]
+ fn issue_3925_dont_flag_simple_past_forms() {
+ assert_no_lints(
+ "He fought tenaciously. He wrought tenaciously.",
+ test_linter(),
+ );
+ }
+
// Every pronoun systematically
// Expected to get corrected
diff --git a/harper-core/tests/text/tagged/Difficult sentences.md b/harper-core/tests/text/tagged/Difficult sentences.md
index 8afd49c65..17c444c00 100644
--- a/harper-core/tests/text/tagged/Difficult sentences.md
+++ b/harper-core/tests/text/tagged/Difficult sentences.md
@@ -269,7 +269,7 @@
> I've lived here for three years .
# K VP/J J/R R/C/P NSg NPl+ .
> They fought for days over a silly pencil .
-# IPl+ VB R/C/P NPl+ NSg/J/P D/P+ NSg/J+ NSg/VB+ .
+# IPl+ VP R/C/P NPl+ NSg/J/P D/P+ NSg/J+ NSg/VB+ .
> The store is closed for the day .
# D+ NSg/VB+ VL3 VP/J R/C/P D+ NPr🅪Sg+ .
> I can see for miles .
diff --git a/harper-core/tests/text/tagged/The Great Gatsby.md b/harper-core/tests/text/tagged/The Great Gatsby.md
index 6f127cc7e..3b5fae960 100644
--- a/harper-core/tests/text/tagged/The Great Gatsby.md
+++ b/harper-core/tests/text/tagged/The Great Gatsby.md
@@ -8675,7 +8675,7 @@
> word she was drawing further and further into herself , so he gave that up , and
# NSg/VB+ ISg+ VLPt N🅪Sg/Vg/J VB/JC VB/C VB/JC P ISg+ . NSg/I/J/R/C NPr/ISg+ VPt I/C/Ddem+ NSg/VB/J/P . VB/C
> only the dead dream fought on as the afternoon slipped away , trying to touch
-# J/R/C D+ NSg/VB/J+ NSg/VB/J+ VB J/P R/C/P D+ N🅪Sg+ VP/J VB/J . Nᴹ/Vg/J P N🅪Sg/VB
+# J/R/C D+ NSg/VB/J+ NSg/VB/J+ VP J/P R/C/P D+ N🅪Sg+ VP/J VB/J . Nᴹ/Vg/J P N🅪Sg/VB
> what was no longer tangible , struggling unhappily , undespairingly , toward that
# NSg/I+ VLPt NSg/Dq/P NSg/JC NSg/J . Nᴹ/Vg/J R . ? . J/P I/C/Ddem+
> lost voice across the room .