Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix(core): issue raised by coworker

Elijah Pottere925235db5be
diff --git a/harper-core/src/linting/lint_group.rs b/harper-core/src/linting/lint_group.rs
index fe1a5471e..6045d29f0 100644
--- a/harper-core/src/linting/lint_group.rs
+++ b/harper-core/src/linting/lint_group.rs
@@ -1,6 +1,8 @@
use paste::paste;
use serde::{Deserialize, Serialize};
+//
+
use super::an_a::AnA;
use super::avoid_curses::AvoidCurses;
use super::boring_words::BoringWords;
diff --git a/harper-core/src/linting/pronoun_contraction/avoid_contraction.rs b/harper-core/src/linting/pronoun_contraction/avoid_contraction.rs
index 073cf22ac..c7c93acee 100644
--- a/harper-core/src/linting/pronoun_contraction/avoid_contraction.rs
+++ b/harper-core/src/linting/pronoun_contraction/avoid_contraction.rs
@@ -11,7 +11,11 @@ pub struct AvoidContraction {
impl Default for AvoidContraction {
fn default() -> Self {
- let pattern = SequencePattern::aco("you're").then_whitespace().then_noun();
+ let pattern = SequencePattern::aco("you're")
+ .then_whitespace()
+ .then(Box::new(|tok: &Token, _source: &[char]| {
+ tok.kind.is_noun() && !tok.kind.is_adjective()
+ }));
Self {
pattern: Box::new(pattern),
diff --git a/harper-core/src/linting/pronoun_contraction/mod.rs b/harper-core/src/linting/pronoun_contraction/mod.rs
index fafa4f3b5..b20c2b02b 100644
--- a/harper-core/src/linting/pronoun_contraction/mod.rs
+++ b/harper-core/src/linting/pronoun_contraction/mod.rs
@@ -11,7 +11,7 @@ merge_linters! {PronounContraction => ShouldContract, AvoidContraction => "Choos
#[cfg(test)]
mod tests {
use super::PronounContraction;
- use crate::linting::tests::assert_suggestion_result;
+ use crate::linting::tests::{assert_lint_count, assert_suggestion_result};
#[test]
fn issue_225() {
@@ -48,4 +48,13 @@ mod tests {
"Your car is black.",
);
}
+
+ #[test]
+ fn allows_you_are_still() {
+ assert_lint_count(
+ "In case you're still not convinced.",
+ PronounContraction::default(),
+ 0,
+ );
+ }
}