Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

feat: holly war → holy war (#2222)

Andrew Dunbareac891213fa5
diff --git a/harper-core/src/linting/phrase_set_corrections/mod.rs b/harper-core/src/linting/phrase_set_corrections/mod.rs
index 0de592e81..44f26e02e 100644
--- a/harper-core/src/linting/phrase_set_corrections/mod.rs
+++ b/harper-core/src/linting/phrase_set_corrections/mod.rs
@@ -353,6 +353,15 @@ pub fn lint_group() -> LintGroup {
"Corrects common misspellings of the idiom `get rid of`.",
LintKind::Typo
),
+ "HolyWar" => (
+ &[
+ (&["holey war", "holly war"], &["holy war"]),
+ (&["holey wars", "holly wars"], &["holy wars"]),
+ ],
+ "Literally for religious conflicts and metaphorically for tech preference debats, the correct spelling is `holy war`.",
+ "Corrects misspellings of `holy war`.",
+ LintKind::Malapropism
+ ),
"HowItLooksLike" => (
&[
(&["how he looks like"], &["how he looks", "what he looks like"]),
diff --git a/harper-core/src/linting/phrase_set_corrections/tests.rs b/harper-core/src/linting/phrase_set_corrections/tests.rs
index 9eb238602..ef1d928ed 100644
--- a/harper-core/src/linting/phrase_set_corrections/tests.rs
+++ b/harper-core/src/linting/phrase_set_corrections/tests.rs
@@ -934,6 +934,27 @@ fn got_ride_of() {
);
}
+// HolyWar
+
+#[test]
+#[ignore = "Known failure due to replace_with_match_case working by character index"]
+fn correct_holy_war() {
+ assert_suggestion_result(
+ "I know it is Holly War about idempotent in HTTP and DELETE",
+ lint_group(),
+ "I know it is Holy War about idempotent in HTTP and DELETE",
+ );
+}
+
+#[test]
+fn correct_holly_wars() {
+ assert_suggestion_result(
+ "Anyway I'm not starting some holly wars about this point.",
+ lint_group(),
+ "Anyway I'm not starting some holy wars about this point.",
+ );
+}
+
// HowItLooksLike
#[test]