Skip to content

Offline, privacy-first grammar checker. Fast, open-source, Rust-powered

fix(core): improve the initialisms linter for all-caps inputs (#2184)

Elijah Pottered21fe2d1288
diff --git a/harper-core/src/linting/initialism_linter.rs b/harper-core/src/linting/initialism_linter.rs
index b29d7df59..270201215 100644
--- a/harper-core/src/linting/initialism_linter.rs
+++ b/harper-core/src/linting/initialism_linter.rs
@@ -37,20 +37,14 @@ impl ExprLinter for InitialismLinter {
let tok = matched_tokens.first()?;
let source = tok.span.get_content(source);
- let caps = source
- .iter()
- .map(char::is_ascii_uppercase)
- .chain([false].into_iter().cycle());
-
let mut expansion_lower = self.expansion_lower.to_owned();
+ let first_letter = &mut expansion_lower[0][0];
- for (word, cap) in expansion_lower.iter_mut().zip(caps) {
- word[0] = if cap {
- word[0].to_ascii_uppercase()
- } else {
- word[0].to_ascii_lowercase()
- }
- }
+ *first_letter = if source[0].is_ascii_uppercase() {
+ first_letter.to_ascii_uppercase()
+ } else {
+ first_letter.to_ascii_lowercase()
+ };
let phrase = Itertools::intersperse_with(expansion_lower.into_iter(), || vec![' '])
.reduce(|mut left, mut right| {
diff --git a/harper-core/src/linting/initialisms.rs b/harper-core/src/linting/initialisms.rs
index 69d154d42..36668ab44 100644
--- a/harper-core/src/linting/initialisms.rs
+++ b/harper-core/src/linting/initialisms.rs
@@ -118,4 +118,13 @@ mod tests {
"Really excited for this.",
);
}
+
+ #[test]
+ fn issue_2181() {
+ assert_suggestion_result(
+ "AFAIK, we don't currently have an issue for it.",
+ lint_group(),
+ "As far as i know, we don't currently have an issue for it.",
+ );
+ }
}