Compress tool outputs, logs, files, and RAG chunks before they reach the LLM. 20% fewer tokens for coding agents, 60-95% fewer tokens for JSON, same answers. Library, proxy, MCP server.
Python agentaianthropicclaude-codecompressioncontext-engineeringcontext-windowcursorfastapilangchainllmmcpopenaiprompt-engineeringproxypythonragtoken-optimizationtokenstypescript
fix(proxy): fsync savings dir after atomic rename (#1764)
inix7de2c1e4c2ca
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 900102b54..ff255c832 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -8,6 +8,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0## Unreleased+### Fixed+- **proxy:** the savings store now fsyncs its parent directory after the+ atomic rename, so the most recent `proxy_savings.json` write survives a+ power-loss or crash. `_save_locked` fsynced the temp file's contents but+ never the directory entry the rename created, leaving the rename itself+ non-durable on POSIX. Best-effort — a no-op on Windows and virtual+ filesystems where directory fsync is unsupported.+### Changed* **telemetry:** anonymous usage telemetry is now **opt-in** (off by default) instead of opt-out. Nothing is collected or sent unless you set `HEADROOM_TELEMETRY=on` or pass `--telemetry` to `headroom proxy` / `headroom install apply`. `is_telemetry_enabled()` is fail-closed — only explicit on-values (`on`/`true`/`1`/`yes`/`enable`/`enabled`) enable it; unset, empty, or unrecognized values stay disabled. The existing `--no-telemetry` flag and `HEADROOM_TELEMETRY=off` remain accepted for back-compat, and install manifests now write the `HEADROOM_TELEMETRY` value explicitly so generated deployments are unambiguous.diff --git a/headroom/proxy/savings_tracker.py b/headroom/proxy/savings_tracker.pyindex b5ac322bf..92852bce2 100644--- a/headroom/proxy/savings_tracker.py+++ b/headroom/proxy/savings_tracker.py@@ -1122,6 +1122,23 @@ class SavingsTracker:except OSError:passraise++ # Persist the rename itself — the fsync above flushed the file's+ # bytes, but the directory entry the rename created isn't durable+ # until the parent directory is fsynced too (POSIX). Best-effort —+ # directory fsync is unsupported on Windows and some virtual+ # filesystems; the file and atomic rename are already durable, so a+ # failure here only forgoes the last-save crash guarantee, never+ # correctness. (FP4b)+ try:+ dir_fd = os.open(self._path.parent, os.O_RDONLY)+ try:+ os.fsync(dir_fd)+ finally:+ os.close(dir_fd)+ except OSError:+ pass+# Reset only after a durable write. A failed save leaves the counter# untouched so the next record retries instead of waiting a full window.self._since_save = 0diff --git a/tests/test_proxy_savings_history.py b/tests/test_proxy_savings_history.pyindex 822a4c890..791e01fb7 100644--- a/tests/test_proxy_savings_history.py+++ b/tests/test_proxy_savings_history.py@@ -5,6 +5,8 @@ from __future__ import annotationsimport asyncioimport jsonimport math+import os+import statimport tempfilefrom datetime import datetime, timedelta, timezonefrom pathlib import Path@@ -296,6 +298,66 @@ def test_savings_tracker_save_does_not_flock_target_inode_before_replace(tmp_patassert persisted["lifetime"]["tokens_saved"] == 15+def test_savings_tracker_save_fsyncs_parent_directory(tmp_path, monkeypatch):+ # The file fsync persists contents, but the rename isn't durable until the+ # parent directory is fsynced too — without it a crash can drop the last+ # save. Assert a directory fd is fsynced on save. (FP4b)+ path = tmp_path / "proxy_savings.json"+ tracker = SavingsTracker(path=str(path))++ real_fsync = os.fsync+ dir_fds_synced: list[int] = []++ def _spy_fsync(fd: int) -> None:+ try:+ if stat.S_ISDIR(os.fstat(fd).st_mode):+ dir_fds_synced.append(fd)+ except OSError:+ pass+ real_fsync(fd)++ monkeypatch.setattr(savings_tracker_module.os, "fsync", _spy_fsync)++ tracker.record_request(+ model="gpt-4o",+ input_tokens=120,+ tokens_saved=10,+ timestamp="2026-03-27T09:00:00Z",+ )++ # Parent directory fsynced (rename durable) and the save still landed intact.+ assert dir_fds_synced, "parent directory was never fsynced after os.replace"+ persisted = json.loads(path.read_text(encoding="utf-8"))+ assert persisted["lifetime"]["tokens_saved"] == 10+++def test_savings_tracker_save_survives_directory_fsync_failure(tmp_path, monkeypatch):+ # On Windows and some virtual filesystems the directory fsync fails — the+ # save must still complete because the file and atomic rename are already+ # durable on their own. (FP4b)+ path = tmp_path / "proxy_savings.json"+ tracker = SavingsTracker(path=str(path))++ real_open = os.open++ def _failing_open(target, *args, **kwargs):+ if str(target) == str(path.parent):+ raise OSError("directory fsync unsupported")+ return real_open(target, *args, **kwargs)++ monkeypatch.setattr(savings_tracker_module.os, "open", _failing_open)++ tracker.record_request(+ model="gpt-4o",+ input_tokens=120,+ tokens_saved=10,+ timestamp="2026-03-27T09:00:00Z",+ )++ persisted = json.loads(path.read_text(encoding="utf-8"))+ assert persisted["lifetime"]["tokens_saved"] == 10++def test_litellm_resolution_and_savings_estimation_fallbacks(monkeypatch):def fake_cost_per_token(*, model, prompt_tokens, completion_tokens):if model in {"gpt-4o", "anthropic/claude-sonnet-4-6"}: