Skip to content

Compress tool outputs, logs, files, and RAG chunks before they reach the LLM. 20% fewer tokens for coding agents, 60-95% fewer tokens for JSON, same answers. Library, proxy, MCP server.

fix(install): parse Windows Task Scheduler XML output (#3830)

Ralf Escherc32a4f413193
diff --git a/headroom/install/supervisors.py b/headroom/install/supervisors.py
index 3a0fe96af..7591c1b18 100644
--- a/headroom/install/supervisors.py
+++ b/headroom/install/supervisors.py
@@ -337,6 +337,22 @@ def _windows_health_trigger() -> str:
)
+def _parse_windows_task_xml(raw: bytes | str) -> ElementTree.Element:
+ """Parse schtasks XML when its declaration does not match stdout bytes."""
+ if isinstance(raw, bytes):
+ try:
+ return ElementTree.fromstring(raw)
+ except ElementTree.ParseError:
+ raw = raw.decode(errors="replace")
+ normalized = re.sub(
+ r'<\?xml\s+version="1\.0"\s+encoding="[^"]+"\?>',
+ '<?xml version="1.0"?>',
+ raw,
+ count=1,
+ )
+ return ElementTree.fromstring(normalized)
+
+
def _register_windows_task(name: str, xml: str, *, expected_logon_type: str) -> None:
"""Register a task and verify its principal from Task Scheduler's XML."""
@@ -364,7 +380,7 @@ def _register_windows_task(name: str, xml: str, *, expected_logon_type: str) ->
) from exc
try:
- task = ElementTree.fromstring(query.stdout or "")
+ task = _parse_windows_task_xml(query.stdout or b"")
except ElementTree.ParseError as exc:
raise _WindowsTaskRegistrationError(
f"Could not parse registered Windows task {name!r}", task_created=True
diff --git a/tests/test_install/test_supervisors.py b/tests/test_install/test_supervisors.py
index a8700fb67..400b1a648 100644
--- a/tests/test_install/test_supervisors.py
+++ b/tests/test_install/test_supervisors.py
@@ -12,6 +12,7 @@ from headroom.install.supervisors import (
_linux_service_unit,
_linux_task_spec,
_macos_launchd_plist,
+ _parse_windows_task_xml,
_register_windows_task,
_render_unix_runner,
_render_windows_runner,
@@ -94,6 +95,36 @@ def test_register_windows_task_verifies_queried_logon_type(monkeypatch) -> None:
assert calls[1] == ["schtasks", "/Query", "/TN", "headroom-default-health", "/XML"]
+def test_register_windows_task_accepts_mismatched_xml_encoding(monkeypatch) -> None:
+ task_xml = (
+ b'<?xml version="1.0" encoding="UTF-16"?>'
+ b'<Task xmlns="http://schemas.microsoft.com/windows/2004/02/mit/task">'
+ b"<Principals><Principal><LogonType>S4U</LogonType></Principal></Principals>"
+ b"</Task>"
+ )
+
+ def fake_run(command: list[str], **kwargs):
+ if command[1] == "/Query":
+ return _LaunchctlResult(stdout=task_xml)
+ return _LaunchctlResult()
+
+ monkeypatch.setattr("headroom.install.supervisors.subprocess.run", fake_run)
+
+ _register_windows_task("headroom-default-health", "<Task />", expected_logon_type="S4U")
+
+
+def test_parse_windows_task_xml_accepts_valid_bytes() -> None:
+ task = _parse_windows_task_xml(b"<Task><LogonType>S4U</LogonType></Task>")
+
+ assert task.find("LogonType").text == "S4U"
+
+
+def test_parse_windows_task_xml_accepts_text() -> None:
+ task = _parse_windows_task_xml("<Task><LogonType>InteractiveToken</LogonType></Task>")
+
+ assert task.find("LogonType").text == "InteractiveToken"
+
+
def test_register_windows_task_rejects_logon_type_downgrade(monkeypatch) -> None:
def fake_run(command: list[str], **kwargs):
if command[1] == "/Query":