Compress tool outputs, logs, files, and RAG chunks before they reach the LLM. 20% fewer tokens for coding agents, 60-95% fewer tokens for JSON, same answers. Library, proxy, MCP server.
Python agentaianthropicclaude-codecompressioncontext-engineeringcontext-windowcursorfastapilangchainllmmcpopenaiprompt-engineeringproxypythonragtoken-optimizationtokenstypescript
fix(savings): guard non-finite numeric coercion (#1769)
inixf4ecdebb1bf9
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex fd36c2dfd..ece1d2d7e 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -9,6 +9,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0## Unreleased### Fixed+- Non-finite values (`NaN`, `Infinity`) in `proxy_savings.json` or in upstream+ cost/token metadata no longer crash the proxy or corrupt the savings+ dashboard. `SavingsTracker`'s numeric coercion caught only `TypeError` and+ `ValueError`, so `int(float('inf'))` raised an uncaught `OverflowError` while+ loading persisted state (`SavingsTracker.__init__` failed and the proxy would+ not start), and `float('nan')`/`float('inf')` passed straight through, then+ serialized to `NaN`/`Infinity` literals that the dashboard's `JSON.parse`+ rejects. `json.loads` accepts those literals, so one bad write poisoned every+ later start. Both coercion helpers now also catch `OverflowError` and reject+ non-finite floats, failing open to safe defaults.- `headroom learn` now honors `CLAUDE_CONFIG_DIR`. It resolved the Claudeconfig directory as `~/.claude` and wrote global memory to`~/.claude/CLAUDE.md`, so users who relocate their Claude config via thatdiff --git a/headroom/proxy/savings_tracker.py b/headroom/proxy/savings_tracker.pyindex 4e82d3d73..30853ffad 100644--- a/headroom/proxy/savings_tracker.py+++ b/headroom/proxy/savings_tracker.py@@ -10,6 +10,7 @@ from __future__ import annotationsimport importlib.utilimport jsonimport logging+import mathimport osimport tempfileimport threading@@ -108,15 +109,20 @@ def _bucket_start(timestamp: datetime, bucket: str) -> datetime:def _coerce_int(value: Any, default: int = 0) -> int:try:return max(int(value), 0)- except (TypeError, ValueError):+ except (TypeError, ValueError, OverflowError):return defaultdef _coerce_float(value: Any, default: float = 0.0) -> float:try:- return max(float(value), 0.0)- except (TypeError, ValueError):+ coerced = float(value)+ except (TypeError, ValueError, OverflowError):return default+ # Reject NaN/inf -- float() accepts them, but they poison arithmetic and+ # serialize to JSON the dashboard's JSON.parse rejects.+ if not math.isfinite(coerced):+ return default+ return max(coerced, 0.0)PROVIDER_UNKNOWN = "unknown"diff --git a/tests/test_proxy_savings_history.py b/tests/test_proxy_savings_history.pyindex dece8eae3..b5b9ac048 100644--- a/tests/test_proxy_savings_history.py+++ b/tests/test_proxy_savings_history.py@@ -4,6 +4,7 @@ from __future__ import annotationsimport asyncioimport json+import mathfrom datetime import datetime, timedelta, timezonefrom pathlib import Pathfrom types import SimpleNamespace@@ -1220,3 +1221,77 @@ def test_stats_history_includes_cli_filtering(tmp_path, monkeypatch):assert data["cli_filtering"]["tool"] == "rtk"assert data["cli_filtering"]["label"] == "RTK"assert data["cli_filtering"]["lifetime"]["tokens_saved"] == 999+++def test_coercion_helpers_reject_non_finite_values():+ """Non-finite inputs fail open to the default -- never raise, never leak NaN/inf.++ _coerce_int raised OverflowError on inf; _coerce_float returned NaN/inf+ verbatim, poisoning arithmetic and emitting JSON the dashboard's JSON.parse+ rejects.+ """+ ci = savings_tracker_module._coerce_int+ cf = savings_tracker_module._coerce_float++ # _coerce_int: every non-finite / overflowing input collapses to default.+ assert ci(float("inf")) == 0+ assert ci(float("-inf")) == 0+ assert ci(float("nan")) == 0+ assert ci(float("inf"), default=7) == 7++ # _coerce_float: nan/inf never raise on float() and must be rejected;+ # an int too large to convert raises OverflowError and must be caught.+ assert cf(float("nan")) == 0.0+ assert math.isfinite(cf(float("nan")))+ assert cf(float("inf")) == 0.0+ assert cf(float("-inf")) == 0.0+ assert cf(10**400) == 0.0+ assert cf(float("nan"), default=1.5) == 1.5++ # Regression: finite values still coerce unchanged.+ assert ci(5) == 5+ assert cf(3.5) == pytest.approx(3.5)+++def test_savings_tracker_loads_non_finite_persisted_state_without_crashing(tmp_path):+ """A proxy_savings.json holding NaN/Infinity must not crash construction.++ json.loads accepts bare NaN/Infinity, so a prior bad write leaves them on+ disk. Before the fix, _coerce_int(inf) in _sanitize_state raised+ OverflowError out of __init__ and the proxy failed to start.+ """+ path = tmp_path / "proxy_savings.json"+ # json.dumps emits bare NaN/Infinity literals (allow_nan default) -- exactly+ # what a prior non-finite write would leave on disk.+ path.write_text(+ json.dumps(+ {+ "schema_version": 3,+ "lifetime": {+ "requests": 1,+ "tokens_saved": float("inf"),+ "compression_savings_usd": float("nan"),+ "total_input_tokens": float("inf"),+ "total_input_cost_usd": float("nan"),+ },+ "history": [+ {+ "timestamp": "2026-03-27T09:00:00Z",+ "total_tokens_saved": float("inf"),+ "compression_savings_usd": float("nan"),+ }+ ],+ }+ ),+ encoding="utf-8",+ )++ tracker = SavingsTracker(path=str(path))+ lifetime = tracker.snapshot()["lifetime"]++ # Non-finite fields fail open to safe defaults, not crash or NaN.+ for key, value in lifetime.items():+ assert isinstance(value, int | float)+ assert math.isfinite(value), f"{key} is non-finite: {value}"+ assert lifetime["tokens_saved"] == 0+ assert lifetime["total_input_tokens"] == 0