The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
"""Tests for GNU long-option abbreviation bypass in DANGEROUS_PATTERNS.
GNU tools accept unique long-option prefix abbreviations at runtime
(e.g. ``chown --recur`` resolves to ``chown --recursive``). Two approval
patterns matched only the full flag name and could be evaded by passing a
valid abbreviation:
chown --recursive → --recur[a-z]*
git push --force → --forc[a-z]*
The other long-flag patterns (rm/chmod/sed) were already covered on every
abbreviation by sibling short-flag / target patterns, so this file only
asserts the two gaps that were genuinely open plus the relevant regression
guards.
"""
from tools.approval import detect_dangerous_command
class TestChownRecursiveLongOptionAbbreviation:
"""chown --recur* abbreviations targeting root must be caught.
On main the bare ``--recur root`` form is caught only by an accidental
case-insensitive ``r`` → ``R`` overlap with the short-flag pattern; longer
abbreviations like ``--recurs``/``--recursi`` break that overlap and
slipped through before the prefix change.
"""
def test_chown_recursive_full_still_detected(self):
dangerous, _, desc = detect_dangerous_command("chown --recursive root /etc")
assert dangerous is True
assert "chown" in desc.lower() or "root" in desc.lower()
def test_chown_recur_non_root_not_flagged(self):
"""--recur* chown to a non-root user must not be flagged."""
dangerous, _, _ = detect_dangerous_command("chown --recur nobody /opt/app")
assert dangerous is False
class TestGitPushForceLongOptionAbbreviation:
"""git push --forc* abbreviations must be caught.
The short ``-f`` pattern does not catch ``--forc`` (the ``\\b`` after the
``f`` does not match mid-word), so abbreviated long forms slipped through.
"""
def test_git_push_force_full_still_detected(self):
dangerous, _, desc = detect_dangerous_command("git push --force origin main")
assert dangerous is True
assert "force" in desc.lower()
def test_git_push_short_f_still_detected(self):
"""Existing -f pattern must not regress."""
dangerous, _, _ = detect_dangerous_command("git push -f origin main")
assert dangerous is True
def test_git_push_set_upstream_not_flagged(self):
dangerous, _, _ = detect_dangerous_command(
"git push --set-upstream origin feature"
)
assert dangerous is False