The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
fix(browser): raw CDP keeps the cloud-metadata floor when the private-URL guard is off
Teknium09660feb36d4
diff --git a/tests/tools/test_browser_eval_ssrf.py b/tests/tools/test_browser_eval_ssrf.pyindex 219429bd0a0..04f2922f296 100644--- a/tests/tools/test_browser_eval_ssrf.py+++ b/tests/tools/test_browser_eval_ssrf.py@@ -85,3 +85,14 @@ class TestExpressionScanHelper:monkeypatch.setattr(browser_url_policy, "is_always_blocked_url", lambda url: False)out = browser_url_policy.expression_targets_private_url("location.href='http://10.0.0.1/';")assert out == "http://10.0.0.1/"++[email protected]("local_backend,allow_private", [(True, False), (False, True)])+def test_raw_cdp_keeps_the_metadata_floor_when_the_private_guard_is_off(monkeypatch, local_backend, allow_private):+ from tools import browser_cdp_tool, browser_session_cloud+ monkeypatch.setattr(browser_session_cloud, "is_local_backend", lambda: local_backend)+ monkeypatch.setattr(browser_session_cloud, "allow_private_urls", lambda: allow_private)+ guard = browser_cdp_tool._browser_cdp_private_guard+ for method in ("Page.navigate", "Target.createTarget"):+ assert "cloud metadata" in guard(method=method, params={"url": "http://169.254.169.254/latest/meta-data/"})+ assert guard(method=method, params={"url": "http://192.168.1.5/"}) is Nonediff --git a/tools/browser_cdp_tool.py b/tools/browser_cdp_tool.pyindex e8fe898283e..7e41336f859 100644--- a/tools/browser_cdp_tool.py+++ b/tools/browser_cdp_tool.py@@ -207,6 +207,13 @@ def _browser_cdp_private_guard(*, method: str, params: dict[str, Any], endpoint:"""from tools.browser_url_policy import eval_ssrf_guard_activeif not eval_ssrf_guard_active():+ # The cloud-metadata floor stays unconditional, as in browser_exec's _url_policy_error (#16234).+ target_url = str((params or {}).get("url") or "").strip()+ if method in ("Page.navigate", "Target.createTarget") and target_url:+ from tools.url_safety import is_always_blocked_url+ if is_always_blocked_url(target_url):+ return _blocked(f"Blocked: CDP {method} url targets a cloud metadata endpoint ({target_url}).",+ method)return Noneguard = _METHOD_PARAM_GUARDS.get(method)if guard is not None: