Skip to content

The agent that grows with you

fix(left-core): doctor consumes no kept migration notice

Teknium0bfcc6423fda
diff --git a/hermes_cli/left_core_migration.py b/hermes_cli/left_core_migration.py
index a2df0f30613..a2e7e506db6 100644
--- a/hermes_cli/left_core_migration.py
+++ b/hermes_cli/left_core_migration.py
@@ -594,7 +594,7 @@ def recover_for_provider(name: Optional[str]) -> None:
``hermes update`` migrated. Outcomes print in a declared terminal front end (:func:`serve_notices_on_stderr`),
else wait for the home's first agent."""
feature = _provider_feature(name or "")
- if feature is None:
+ if feature is None or _installs_held.get(): # held: a read-only diagnostic consumes no kept notice either
return
from hermes_constants import get_hermes_home, hermes_home_key
from providers import get_provider_profile
diff --git a/tests/hermes_cli/test_left_core_provider_runtime.py b/tests/hermes_cli/test_left_core_provider_runtime.py
index f47dfbcf9a4..64aa8b69654 100644
--- a/tests/hermes_cli/test_left_core_provider_runtime.py
+++ b/tests/hermes_cli/test_left_core_provider_runtime.py
@@ -118,6 +118,24 @@ def test_doctor_installs_nothing_and_names_the_install(tmp_path, monkeypatch, in
assert "hermes plugins install github-copilot" in capsys.readouterr().out
+def test_doctor_in_a_terminal_front_end_leaves_kept_notices_for_the_next_agent(tmp_path, monkeypatch, installs,
+ capsys):
+ """The classic CLI runs doctor in-process (console engine): a read-only diagnostic neither prints nor
+ consumes what a migration kept for the home's next agent."""
+ from types import SimpleNamespace
+ from hermes_cli import doctor
+ from hermes_cli.doctor_config import _check_config_file
+ home = _copilot_home(tmp_path, monkeypatch, "model:\n provider: nous\nauxiliary:\n vision:\n"
+ " provider: copilot\n model: gpt-4.1\n")
+ lcm._queue_notice(home, "kept by the gateway's start")
+ lcm.serve_notices_on_stderr()
+ monkeypatch.setattr(doctor, "HERMES_HOME", home)
+ monkeypatch.setattr(doctor, "DOCTOR_CHECKS", ((None, _check_config_file),))
+ doctor.run_doctor(SimpleNamespace(fix=False, ack=None, live=False))
+ assert "kept by the gateway's start" not in capsys.readouterr().err
+ assert lcm._claim_notices(home) == ["kept by the gateway's start"]
+
+
@pytest.fixture
def installs_ok(monkeypatch):
calls = []