Skip to content

The agent that grows with you

fix(backend): BOM-tolerant token file reads; decoding errors name the variable

ethernet18c4b372a8a0
diff --git a/hermes_cli/web_server.py b/hermes_cli/web_server.py
index 92044137c66..0afabccda22 100644
--- a/hermes_cli/web_server.py
+++ b/hermes_cli/web_server.py
@@ -231,8 +231,8 @@ def _resolve_session_token() -> str:
token_file = os.environ.get("HERMES_DASHBOARD_SESSION_TOKEN_FILE")
if token_file:
try:
- token = Path(token_file).read_text(encoding="utf-8").strip()
- except OSError as exc:
+ token = Path(token_file).read_text(encoding="utf-8-sig").strip()
+ except (OSError, UnicodeError) as exc:
raise SystemExit(
f"HERMES_DASHBOARD_SESSION_TOKEN_FILE names an unreadable file ({token_file}): {exc}"
) from exc
diff --git a/tests/hermes_cli/test_dashboard_session_token_file.py b/tests/hermes_cli/test_dashboard_session_token_file.py
index 9ac3027e7bf..7450ccd35c7 100644
--- a/tests/hermes_cli/test_dashboard_session_token_file.py
+++ b/tests/hermes_cli/test_dashboard_session_token_file.py
@@ -47,6 +47,18 @@ def test_empty_token_file_fails_loudly(monkeypatch, tmp_path):
web_server._resolve_session_token()
+def test_malformed_token_file_fails_loudly(monkeypatch, tmp_path):
+ from hermes_cli import web_server
+
+ token_file = tmp_path / "token"
+ token_file.write_bytes(b"\xff\xfe\x00not-utf8")
+ monkeypatch.delenv("HERMES_DASHBOARD_SESSION_TOKEN", raising=False)
+ monkeypatch.setenv("HERMES_DASHBOARD_SESSION_TOKEN_FILE", str(token_file))
+
+ with pytest.raises(SystemExit, match="unreadable"):
+ web_server._resolve_session_token()
+
+
def test_no_source_mints_a_token(monkeypatch):
from hermes_cli import web_server