The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
test(desktop): the blocked-storage tests block storage on every supported Node
emozilla20bb918ae501
diff --git a/apps/desktop/src/lib/browser-desktop-bridge-settings.test.ts b/apps/desktop/src/lib/browser-desktop-bridge-settings.test.tsindex 70cc2eed268..27c689b529b 100644--- a/apps/desktop/src/lib/browser-desktop-bridge-settings.test.ts+++ b/apps/desktop/src/lib/browser-desktop-bridge-settings.test.ts@@ -1,6 +1,7 @@import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'import { $connection } from '@/store/session'+import { pageStorage } from '@/test/page-storage'import { clearWebappSession, seedWebappSession } from '@/test/webapp-session'import { installBrowserDesktopBridge } from './browser-desktop-bridge'@@ -52,11 +53,12 @@ describe('browser default project folder', () => {})it('rejects a choice this browser cannot keep instead of reporting it saved', async () => {- vi.spyOn(localStorage, 'setItem').mockImplementation(() => {+ const write = vi.spyOn(pageStorage(), 'setItem').mockImplementation(() => {throw new Error('storage denied')})await expect(reload().setDefaultProjectDir('/srv/repos/app')).rejects.toThrow()+ expect(write).toHaveBeenCalled()expect((await reload().getDefaultProjectDir()).dir).toBeNull()})})diff --git a/apps/desktop/src/lib/browser-desktop-bridge-zoom.test.ts b/apps/desktop/src/lib/browser-desktop-bridge-zoom.test.tsindex cf10f8cf65a..15ca8fb071c 100644--- a/apps/desktop/src/lib/browser-desktop-bridge-zoom.test.ts+++ b/apps/desktop/src/lib/browser-desktop-bridge-zoom.test.ts@@ -1,5 +1,6 @@import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'+import { pageStorage } from '@/test/page-storage'import { clearWebappSession, seedWebappSession } from '@/test/webapp-session'import { installBrowserDesktopBridge } from './browser-desktop-bridge'@@ -53,16 +54,20 @@ describe('browser UI scale', () => {})it('keeps scaling usable when storage is blocked and rejects invalid scale inputs', async () => {- vi.spyOn(localStorage, 'getItem').mockImplementation(() => {+ const read = vi.spyOn(pageStorage(), 'getItem').mockImplementation(() => {throw new Error('storage denied')})- vi.spyOn(localStorage, 'setItem').mockImplementation(() => {++ const write = vi.spyOn(pageStorage(), 'setItem').mockImplementation(() => {throw new Error('storage denied')})+const zoom = createBrowserZoom('')const resized = vi.fn()window.addEventListener('resize', resized)zoom.setPercent(175)+ expect(read).toHaveBeenCalled()+ expect(write).toHaveBeenCalled()expect(document.documentElement.style.zoom).toBe('1.75')expect((await zoom.get()).percent).toBe(175)expect(resized).toHaveBeenCalledTimes(1)diff --git a/apps/desktop/src/test/page-storage.ts b/apps/desktop/src/test/page-storage.tsnew file mode 100644index 00000000000..6801dbd5241--- /dev/null+++ b/apps/desktop/src/test/page-storage.ts@@ -0,0 +1,13 @@+/**+ * The object that holds `window.localStorage`'s methods, for spying on the page's storage reads+ * and writes. On Node 22 that is jsdom's `Storage.prototype`: a spy defined on the instance is kept+ * as a stored item and never intercepts a call. From Node 25 the test setup installs a plain+ * in-memory storage (see vitest.setup.ts) whose methods are its own and whose prototype has none.+ */+export function pageStorage(): Storage {+ const storage = window.localStorage++ return Object.prototype.hasOwnProperty.call(storage, 'setItem')+ ? storage+ : (Object.getPrototypeOf(storage) as Storage)+}