The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
fix(deps): pin Electron 44.9.3 and drop the 40.10.2-era install config
ethernet21693bdf29f2
diff --git a/.github/workflows/windows-desktop-attach-e2e.yml b/.github/workflows/windows-desktop-attach-e2e.ymlindex f03f2197e2d..ac4c08e6098 100644--- a/.github/workflows/windows-desktop-attach-e2e.yml+++ b/.github/workflows/windows-desktop-attach-e2e.yml@@ -38,11 +38,16 @@ jobs:extras: '[]'test-environment: 'true'- # Full npm ci (not --ignore-scripts): electron's postinstall downloads the binary we launch.+ # Full npm ci (not --ignore-scripts): native addons need their lifecycle scripts.- uses: ./.github/actions/retrywith:command: npm ci+ # Electron 42+ has no postinstall; unpack the binary the attach spec launches.+ - name: Prepare locked Electron runtime+ shell: bash+ run: node scripts/build/electron-runtime.mjs --source .+- name: Build the desktop appworking-directory: apps/desktopshell: bashdiff --git a/.npmrc b/.npmrcindex 6bc302a0c88..ce25755bb46 100644--- a/.npmrc+++ b/.npmrc@@ -69,7 +69,6 @@ min-release-age-exclude[]=vitestmin-release-age-exclude[]=@vitest/*-# electron 44.4.5 (2026-09-22) fixes GHSA-r4w5-6pfg-jxp5 / GHSA-9f4c-93c8-jc8g,-# the NVIDIA 580 EGL probe crash (#124032) and the glibc 2.41 loader abort-# (#88330). remove this when it is > 2wks old.+# electron 44.9.3 backports upstream Chromium/V8 security fixes, and 44.9.1+ carries the+# eMudhra root distrust per #142533. remove when 44.9.3 is > 2wks old (rel 2026-10-21)min-release-age-exclude[]=electrondiff --git a/apps/desktop/electron/desktop-electron-pin.test.ts b/apps/desktop/electron/desktop-electron-pin.test.tsindex 33e983bf747..6e19f217a3a 100644--- a/apps/desktop/electron/desktop-electron-pin.test.ts+++ b/apps/desktop/electron/desktop-electron-pin.test.ts@@ -5,14 +5,15 @@* changed its install mechanism mid patch-series:** electron 40.9.3 .. 40.10.2 -> @electron/get@^2 + extract-zip@^2 (pure JS)- * electron 40.10.3 / 40.10.4 -> @electron/get@^5 ++ * electron 40.10.3 and later -> @electron/get@^5 +* @electron-internal/extract-zip@^1 (native napi)** ``apps/desktop/package.json`` declared ``electronVersion: 40.9.3`` (the tested,* JS-extract build) but pinned the dependency loosely as ``electron: ^40.9.3``.* ``npm ci`` then resolved 40.10.3/40.10.4 — the new *native* extract-zip whose- * win32-x64 binding fails to ``dlopen`` on some Windows hosts- * (``ERR_DLOPEN_FAILED loading index.win32-x64-msvc.node``).+ * win32 binding imports VCRUNTIME140.dll and fails to ``dlopen`` on hosts without+ * the VC++ runtime (``ERR_DLOPEN_FAILED loading index.win32-x64-msvc.node``).+ * scripts/build/electron-runtime.mjs now supplies that DLL.** These tests lock the contract that prevents that drift, without hard-coding the* specific version (which is allowed to move):diff --git a/apps/desktop/electron/renderer-log.ts b/apps/desktop/electron/renderer-log.tsindex 984d38ec63b..e143c4a981f 100644--- a/apps/desktop/electron/renderer-log.ts+++ b/apps/desktop/electron/renderer-log.ts@@ -60,7 +60,7 @@ function isConsoleMessageDetails(value: unknown): value is ConsoleMessageDetails}/** Format Electron's canonical console-message event object into one line, or- * null for non-error or malformed events. Hermes's pinned Electron 40.x line+ * null for non-error or malformed events. Hermes's pinned Electron line* puts severity and source metadata on the event object itself; accepting one* listener argument also avoids Electron's deprecated positional* `(event, level, message, line, sourceId)` path. */diff --git a/apps/desktop/package.json b/apps/desktop/package.jsonindex 3dc630edcd0..b8e33c34636 100644--- a/apps/desktop/package.json+++ b/apps/desktop/package.json@@ -185,7 +185,7 @@"bippy": "0.5.43","concurrently": "10.0.6","cross-env": "10.1.0",- "electron": "44.4.5",+ "electron": "44.9.3","electron-builder": "27.0.0-alpha.6","esbuild": "0.28.1","jsdom": "29.1.1",diff --git a/package-lock.json b/package-lock.jsonindex 26349929bfa..e4f9e5e24c7 100644--- a/package-lock.json+++ b/package-lock.json@@ -154,8 +154,8 @@"use-stick-to-bottom": "1.1.6","vfile": "6.0.3","web-haptics": "0.0.6",- "yaml": "2.9.1",- "ws": "^8.21.1"+ "ws": "^8.21.1",+ "yaml": "2.9.1"},"devDependencies": {"@babel/core": "8.0.1",@@ -178,7 +178,7 @@"bippy": "0.5.43","concurrently": "10.0.6","cross-env": "10.1.0",- "electron": "44.4.5",+ "electron": "44.9.3","electron-builder": "27.0.0-alpha.6","esbuild": "0.28.1","jsdom": "29.1.1",@@ -9503,9 +9503,9 @@}},"node_modules/electron": {- "version": "44.4.5",- "resolved": "https://registry.npmjs.org/electron/-/electron-44.4.5.tgz",- "integrity": "sha512-SjgoaeYsSWZfJzubgQU7juvuXMTvn6/e1gAHdGFA/yuMbpF+I+skYqIJ6DdXBXHeWbkbpNpmwZCTpiivtlWZSw==",+ "version": "44.9.3",+ "resolved": "https://registry.npmjs.org/electron/-/electron-44.9.3.tgz",+ "integrity": "sha512-Cv9/yMnZxNWsMlIe8T4v//NKHdUvbeyoTJoXE3BIcRxus2meeFaO9h/P3zB5d4cBXum51IgAYrT2QjpIDWKpJA==","dev": true,"license": "MIT","dependencies": {@@ -11719,8 +11719,8 @@"version": "4.3.0","resolved": "https://registry.npmjs.org/http-cache-semantics/-/http-cache-semantics-4.3.0.tgz","integrity": "sha512-M5t5LlJpS1UHMjvwRQVdFHvPISGeLAxNcrWuJkeGh0KxsqCHZ1O3NXZU/8x7cD0BDcGW8kapxMKTvwlqrNkHkA==",- "devOptional": true,- "license": "BSD-2-Clause"+ "license": "BSD-2-Clause",+ "optional": true},"node_modules/http-proxy-agent": {"version": "7.0.2",@@ -12444,14 +12444,6 @@"node": ">=6"}},- "node_modules/json-buffer": {- "version": "3.0.1",- "resolved": "https://registry.npmjs.org/json-buffer/-/json-buffer-3.0.1.tgz",- "integrity": "sha512-4bV5BfR2mqfQTJm+V5tPPdf+ZpuhiIvTuAB5g8kcrXOZpTT/QwwVRWBywX1ozr6lEuPdbHxwaJlm9G6mI2sfSQ==",- "dev": true,- "license": "MIT",- "peer": true- },"node_modules/json-schema-traverse": {"version": "0.4.1","resolved": "https://registry.npmjs.org/json-schema-traverse/-/json-schema-traverse-0.4.1.tgz",@@ -12466,8 +12458,6 @@"dev": true,"license": "MIT"},- "node_modules/json-stringify-safe": {- },"node_modules/json5": {"version": "2.2.3","resolved": "https://registry.npmjs.org/json5/-/json5-2.2.3.tgz",@@ -12517,17 +12507,6 @@"node": ">= 12"}},- "node_modules/keyv": {- "version": "4.5.4",- "resolved": "https://registry.npmjs.org/keyv/-/keyv-4.5.4.tgz",- "integrity": "sha512-oxVHkHR/EJf2CNXnWxRLW6mg7JyCCUcG0DtEGmL2ctUo1PNTin1PUil+r/+4r5MpVgC/fn1kjsx7mjSujKqIpw==",- "dev": true,- "license": "MIT",- "peer": true,- "dependencies": {- "json-buffer": "3.0.1"- }- },"node_modules/khroma": {"version": "2.1.0","resolved": "https://registry.npmjs.org/khroma/-/khroma-2.1.0.tgz",diff --git a/package.json b/package.jsonindex 1b732d33f1b..5d3a9c735c5 100644--- a/package.json+++ b/package.json@@ -51,7 +51,6 @@"isbinaryfile": "5.0.7"},"lodash": "4.18.1",- "yauzl": "^3.3.1","protobufjs": "^8.7.1","brace-expansion": "5.0.12","mermaid": "11.16.1",@@ -80,7 +79,6 @@"[email protected]": true,"[email protected]": true,"[email protected]": true,- "[email protected]": true,"[email protected]": true,"[email protected]": true,"[email protected]": true,