The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
fix(config): a relative AGENT_BROWSER_PROFILE pinned by the v52 step names the absolute path, on update and at the first agent after boot
Teknium24ee063e8247
diff --git a/hermes_cli/config_migrations_browser.py b/hermes_cli/config_migrations_browser.pyindex 353dc479e62..98e5efce744 100644--- a/hermes_cli/config_migrations_browser.py+++ b/hermes_cli/config_migrations_browser.py@@ -121,6 +121,13 @@ def migrate_to_52(results: dict[str, Any], quiet: bool) -> None:if new is not None:browser[key] = newmoved.append(f"{name} → browser.{key}")+ if key == "user_data_dir" and new != value:+ # Resolved against this process's cwd, which need not be where Hermes ran before.+ note = (f"pinned browser.user_data_dir to {new}: {name}={value} was relative to the directory "+ f"Hermes ran in; check that the browser logins are there")+ added.append(note)+ messages.append(f" ✓ {note[0].upper()}{note[1:]}.")+ notices.append(f"{note[0].upper()}{note[1:]}.")if moved:added.append(f"browser: {', '.join(moved)}")messages.append(f" ✓ Moved agent-browser settings from .env to config.yaml: {', '.join(moved)}")diff --git a/tests/hermes_cli/test_config_migration_52_browser.py b/tests/hermes_cli/test_config_migration_52_browser.pyindex a49445cbd9f..6c9dee326ba 100644--- a/tests/hermes_cli/test_config_migration_52_browser.py+++ b/tests/hermes_cli/test_config_migration_52_browser.py@@ -171,6 +171,28 @@ def test_relative_profile_keeps_the_directory_core_used(tmp_path, monkeypatch):assert _raw(home)["browser"]["user_data_dir"] == str(cwd / "prof" / "rel")+def test_a_pinned_relative_profile_names_the_absolute_path_on_update_and_boot(tmp_path, monkeypatch):+ """The relative AGENT_BROWSER_PROFILE was resolved against whatever directory the migrating process ran+ in: `hermes update` and the first agent after a boot migration both name the absolute path pinned."""+ import hermes_cli.left_core_migration as lcm++ monkeypatch.setattr(lcm, "_undelivered", {})+ monkeypatch.delenv("CAMOFOX_URL", raising=False)+ cwd = tmp_path / "work"+ cwd.mkdir()+ monkeypatch.chdir(cwd)+ pinned = str(cwd / "prof" / "rel")+ updated = _home(tmp_path / "a", {"_config_version": 51}, "AGENT_BROWSER_PROFILE=prof/rel\n")+ monkeypatch.setenv("HERMES_HOME", str(tmp_path / "launch"))+ results = _migrate(updated, quiet=True)+ assert any(pinned in note and "prof/rel" in note for note in results["config_added"])++ booted = _home(tmp_path / "b", {"_config_version": 51}, "AGENT_BROWSER_PROFILE=prof/rel\n")+ said = _boot_agents(booted, monkeypatch, starts=1)+ assert _raw(booted)["browser"]["user_data_dir"] == pinned+ assert len(said) == 1 and pinned in said[0] and "prof/rel" in said[0]++def test_falsy_headed_and_unknown_engine_carry_nothing(tmp_path, monkeypatch):monkeypatch.setenv("HERMES_HOME", str(tmp_path / "launch"))home = _home(tmp_path / "a", {"_config_version": 51},