Skip to content

The agent that grows with you

fix(gateway): authority auth-failure cards keep their sign-in / update-key action

alt-glitch3d7e687462ca
diff --git a/agent/managed_worker.py b/agent/managed_worker.py
index d261a42412b..5fbf846b3c5 100644
--- a/agent/managed_worker.py
+++ b/agent/managed_worker.py
@@ -397,7 +397,9 @@ def execute(frame, channel):
frame = {**frame, 'text': content}
before = (getattr(agent, 'session_prompt_tokens', 0) or 0,
getattr(agent, 'session_completion_tokens', 0) or 0)
- result = run_worker_turns(agent, frame, history)
+ # Most failed results name no provider or model; the owner's error card needs the agent's.
+ result = {'provider': getattr(agent, 'provider', None), 'model': getattr(agent, 'model', None),
+ **run_worker_turns(agent, frame, history)}
result['_turn_input_tokens'] = max(0, (getattr(agent, 'session_prompt_tokens', 0) or 0) - before[0])
result['_turn_output_tokens'] = max(0, (getattr(agent, 'session_completion_tokens', 0) or 0) - before[1])
retire_agent(agent)
diff --git a/gateway/run_turn_runner.py b/gateway/run_turn_runner.py
index c4ba2a34ed2..126c30273c5 100644
--- a/gateway/run_turn_runner.py
+++ b/gateway/run_turn_runner.py
@@ -1323,6 +1323,8 @@ class TurnRunner(GatewayTurnProgressMixin, GatewaySessionAgentMixin):
"input_tokens": getattr(agent, "session_prompt_tokens", 0) if has_comp else 0,
"output_tokens": getattr(agent, "session_completion_tokens", 0) if has_comp else 0,
"model": getattr(agent, "model", None) if agent else None,
+ # Most failed results name no provider; the error card's sign-in / update-key action needs it.
+ "provider": getattr(agent, "provider", None) if agent else None,
"context_length": (getattr(comp, "context_length", 0) or 0) if has_comp else 0,
# The rest of the `-z --usage-file` ledger (hermes_cli/oneshot._USAGE_KEYS): a finite
# viewer reads the committed result over `prompt.receipt`, so the projection must keep
diff --git a/tests/gateway/test_authority_turn_error_surface.py b/tests/gateway/test_authority_turn_error_surface.py
index 5e59d7cbd77..3916d52077c 100644
--- a/tests/gateway/test_authority_turn_error_surface.py
+++ b/tests/gateway/test_authority_turn_error_surface.py
@@ -14,8 +14,9 @@ _RATE_LIMITED = {'failure_reason': 'rate_limit', 'failure_retryable': True, 'fai
'error': 'HTTP 429: slow down'}
-def _authority_turn(platform, failure):
- """Run one failed turn through the authority's in-process TurnRunner: ``(response, captured)``."""
+def _authority_turn(platform, failure, identity=None):
+ """Run one failed turn through the authority's in-process TurnRunner: ``(response, captured)``.
+ ``identity`` replaces the result's provider/model with the agent's own attributes."""
from gateway.run_turn_runner import TurnRunner
from gateway.session import SessionSource
from gateway.session_results import execution_result
@@ -23,9 +24,13 @@ def _authority_turn(platform, failure):
from tests.gateway.test_local_viewer_events_submit import _gateway_runner, _RecordingAgent
class _FailingAgent(_RecordingAgent):
+ def __init__(self, **kwargs):
+ super().__init__(**kwargs)
+ vars(self).update(identity or {})
+
def run_conversation(self, message, **kwargs):
return {'final_response': '', 'messages': [], 'failed': True, 'completed': False,
- 'provider': 'nous', 'model': 'free-model', **failure}
+ **({} if identity else {'provider': 'nous', 'model': 'free-model'}), **failure}
ctx = TurnContext(
source=SessionSource(platform=platform, chat_id='sid', user_id='u'),
@@ -82,6 +87,38 @@ def test_a_managed_worker_turn_carries_the_free_tier_failure_to_the_owner():
assert complete['error_surface']['code'] == 'free_tier_at_capacity'
+_AUTH_FAILED = {'failure_reason': 'auth', 'failure_retryable': False, 'error': 'HTTP 401: invalid api key'}
+_OPENROUTER = {'provider': 'openrouter', 'model': 'anthropic/claude-sonnet-4'}
+
+
+def _assert_update_key_card(complete):
+ surface = complete['error_surface']
+ assert (surface['layer'], surface['auth_kind'], surface['api_key_env']) == ('auth', 'api_key', 'OPENROUTER_API_KEY')
+ assert (surface['provider'], surface['model']) == (_OPENROUTER['provider'], _OPENROUTER['model'])
+
+
+def test_an_auth_failure_offers_the_agents_key_action_when_the_result_names_no_provider():
+ """Real failed results (``agent/turn_recovery._failed_turn_result``) carry no provider or model;
+ the card's sign-in / update-key action comes from the agent that ran, as on the TUI path."""
+ _assert_update_key_card(_complete(*_authority_turn(Platform.LOCAL, _AUTH_FAILED, identity=_OPENROUTER)))
+
+
+def test_a_managed_worker_auth_failure_offers_the_agents_key_action(tmp_path, monkeypatch):
+ from agent.managed_worker import accept_result
+ from tests.gateway.test_managed_worker_route_key import _execute, _minimax_frame
+
+ class Identity:
+ def __init__(self, **kwargs):
+ vars(self).update(_OPENROUTER)
+
+ sent = []
+ _execute(_minimax_frame(tmp_path, monkeypatch), monkeypatch, base=Identity, sent=sent,
+ result={'final_response': '', 'failed': True, 'completed': False, **_AUTH_FAILED})
+ frame = next(payload['result'] for kind, payload in sent if kind == 'result')
+ accepted, usage = accept_result(frame)
+ _assert_update_key_card(_complete('', {'result': {**accepted, 'local_viewer': True}, 'usage': usage}))
+
+
def test_a_successful_turn_completes_without_a_surface():
complete = _complete('done', {'result': {'final_response': 'done', 'messages': []}, 'usage': {}})
assert complete['status'] == 'complete' and 'error_surface' not in complete
diff --git a/tests/gateway/test_managed_worker_route_key.py b/tests/gateway/test_managed_worker_route_key.py
index 333997db04c..ee7c47f1df8 100644
--- a/tests/gateway/test_managed_worker_route_key.py
+++ b/tests/gateway/test_managed_worker_route_key.py
@@ -28,7 +28,7 @@ def _minimax_frame(tmp_path, monkeypatch, api_key=None):
return {**frame, 'policy': policy, 'api_key': api_key}
-def _execute(frame, monkeypatch, base=object, built=None):
+def _execute(frame, monkeypatch, base=object, built=None, result=None, sent=None):
from agent import managed_worker as worker
built = {} if built is None else built
@@ -39,7 +39,7 @@ def _execute(frame, monkeypatch, base=object, built=None):
super().__init__(**kwargs)
self.session_prompt_tokens = self.session_completion_tokens = 0
def run_conversation(self, text, **kwargs):
- return {'final_response': 'ok', 'completed': True}
+ return dict(result or {'final_response': 'ok', 'completed': True})
class Store:
def __init__(self, *args): pass
@@ -64,7 +64,8 @@ def _execute(frame, monkeypatch, base=object, built=None):
monkeypatch.setattr('tools.process_registry.process_registry.recover_from_checkpoint', lambda: None)
monkeypatch.setattr('run_agent.AIAgent', Agent)
monkeypatch.setattr('agent.title_generator.wait_for_title_upgrades', lambda: None)
- worker.execute(frame, SimpleNamespace(send=lambda kind, **payload: None))
+ sent = [] if sent is None else sent
+ worker.execute(frame, SimpleNamespace(send=lambda kind, **payload: sent.append((kind, payload))))
return built